Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: Source/core/inspector/InspectorApplicationCacheAgent.cpp

Issue 1085033003: Introduce InspectorIdentifiers<> and use it to assign/lookup LocalFrame and DocumentLoader (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: win build error fixed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorApplicationCacheAgent.cpp
diff --git a/Source/core/inspector/InspectorApplicationCacheAgent.cpp b/Source/core/inspector/InspectorApplicationCacheAgent.cpp
index dae30dabd06e0b4178b3ce0222b2fef04bb6457f..89bc12b67bd648a170346ff0f0ef5b6c4fae2f1b 100644
--- a/Source/core/inspector/InspectorApplicationCacheAgent.cpp
+++ b/Source/core/inspector/InspectorApplicationCacheAgent.cpp
@@ -27,6 +27,7 @@
#include "core/inspector/InspectorApplicationCacheAgent.h"
#include "core/frame/LocalFrame.h"
+#include "core/inspector/InspectorIdentifiers.h"
#include "core/inspector/InspectorPageAgent.h"
#include "core/inspector/InspectorState.h"
#include "core/inspector/InstrumentingAgents.h"
@@ -79,7 +80,8 @@ void InspectorApplicationCacheAgent::updateApplicationCacheStatus(LocalFrame* fr
ApplicationCacheHost::CacheInfo info = host->applicationCacheInfo();
String manifestURL = info.m_manifest.string();
- frontend()->applicationCacheStatusUpdated(m_pageAgent->frameId(frame), manifestURL, static_cast<int>(status));
+ String frameId = InspectorIdentifiers<LocalFrame>::identifier(frame);
+ frontend()->applicationCacheStatusUpdated(frameId, manifestURL, static_cast<int>(status));
}
void InspectorApplicationCacheAgent::networkStateChanged(LocalFrame* frame, bool online)
@@ -105,7 +107,7 @@ void InspectorApplicationCacheAgent::getFramesWithManifests(ErrorString*, RefPtr
String manifestURL = info.m_manifest.string();
if (!manifestURL.isEmpty()) {
RefPtr<TypeBuilder::ApplicationCache::FrameWithManifest> value = TypeBuilder::ApplicationCache::FrameWithManifest::create()
- .setFrameId(m_pageAgent->frameId(toLocalFrame(frame)))
+ .setFrameId(InspectorIdentifiers<LocalFrame>::identifier(toLocalFrame(frame)))
.setManifestURL(manifestURL)
.setStatus(static_cast<int>(host->status()));
result->addItem(value);
« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/inspector/InspectorCSSAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698