DescriptionFix arm/LTO build by moving neon asm files to intrinsics target.
We currently build certain asm files with support for neon instructions by
passing -Wa,-mfpu=neon when building the libvpx target. This won't work under
LTO because of unused argument errors when building the non-asm files. We
cannot use -mfpu=neon here because neon is an optional feature of libvpx
target on Android if use_neon==0, and we presumably don't want the rest of
the files in the target to use neon instructions.
It looks like the right thing to do here is to move the asm files to the
libvpx_intrinsics_neon target, which is already set up to build everything
for neon with -mfpu=neon.
BUG=407544
R=johannkoenig@google.com, thakis@chromium.org, tomfinegan@chromium.org
Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/7f648118deef202a106d6ac8625bbe3b84369229
Patch Set 1 #
Total comments: 6
Patch Set 2 : Move non-neon asm files out of intrinsics target #
Total comments: 2
Patch Set 3 : Fix duplicate rule warning by avoiding copy #
Total comments: 1
Patch Set 4 : Add documentation for gypi #Patch Set 5 : Rebase #
Messages
Total messages: 11 (2 generated)
|