Issue 1084933002: Fix String._substringUnchecked intrinsic on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1084933002: Fix String._substringUnchecked intrinsic on x64. (Closed)

Created:
5 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 8 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Fix String._substringUnchecked intrinsic on x64. It should check sminess of both start and end, not of end only. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=45139

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Vyacheslav Egorov (Google)

5 years, 8 months ago (2015-04-14 13:27:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45139 (presubmit successful).