runtime/vm/intrinsifier_x64.cc - Issue 1084933002: Fix String._substringUnchecked intrinsic on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 1084933002: Fix String._substringUnchecked intrinsic on x64. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_x64.cc

diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc

index 9a5baf3e75234e54c7c6cfd8a4e11481eb4174ba..c39f2c720bd1222fab28bc63ed670a00f8e03140 100644

--- a/runtime/vm/intrinsifier_x64.cc

+++ b/runtime/vm/intrinsifier_x64.cc

@@ -1782,7 +1782,7 @@ void Intrinsifier::OneByteString_substringUnchecked(Assembler* assembler) {

const intptr_t kStartIndexOffset = 2 * kWordSize;

const intptr_t kEndIndexOffset = 1 * kWordSize;

Label fall_through, ok;

- __ movq(RSI, Address(RSP, + kEndIndexOffset));

+ __ movq(RSI, Address(RSP, + kStartIndexOffset));

__ movq(RDI, Address(RSP, + kEndIndexOffset));

__ orq(RSI, RDI);

__ testq(RSI, Immediate(kSmiTagMask));

« no previous file with comments | « no previous file | no next file » | no next file with comments »