Flip remaining GN bots to use MB.

Flip remaining GN bots to use MB.

This CL flips the remaining GN bots that weren't using
MB (the bots on the v8 tryserver and waterfall), and
removes the non-MB code paths from the chromium_gn recipe.

R=machenbach@chromium.org, phajdan.jr@chromium.org
TBR=jochen@chromium.org, machenbach@chromium.org
BUG=454413
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=294955

[Dirk Pranke, 2015-04-21 22:35:41]

This change depends on https://codereview.chromium.org/1083123005/ .

jochen, machenbach: this is just fyi ...

[Paweł Hajdan Jr., 2015-04-21 23:47:52]

LGTM

[Michael Achenbach, 2015-04-22 07:53:18]

LGTM. I assume this might only run base_unittests and the bot won't get much
slower. Please warn me before landing something that slows down the v8 trybots
significantly.

https://codereview.chromium.org/1084793005/diff/1/scripts/slave/recipes/chrom...
File scripts/slave/recipes/chromium_gn.py (right):

https://codereview.chromium.org/1084793005/diff/1/scripts/slave/recipes/chrom...
scripts/slave/recipes/chromium_gn.py:398: additional_compile_targets)
nit: indentation

[Dirk Pranke, 2015-04-22 15:27:08]

On Wed, Apr 22, 2015 at 12:53 AM, <machenbach@chromium.org> wrote:

> LGTM. I assume this might only run base_unittests and the bot won't get
> much
> slower. Please warn me before landing something that slows down the v8
> trybots
> significantly.
>

Yup, will do. We can turn off base_unittests if you want, as well.

-- Dirk

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2015-04-23 01:19:38]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-04-23 01:19:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084793005/1

[commit-bot: I haz the power, 2015-04-23 01:23:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 01:23:42]

Presubmit check for 1084793005-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
Pylint (587 files) (215.62s) failed
************* Module slave.recipes.chromium_gn
W:428,21: Unused variable 'builder_dict' (unused-variable)


tests/masters_test.py (0.51s) failed
ERROR:root:Found unexpected master Chromium on port 8010


Presubmit checks took 217.4s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[Dirk Pranke, 2015-04-23 01:57:29]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2015-04-23 01:57:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1084793005/#ps20001
(title: "fix lint warning")

[commit-bot: I haz the power, 2015-04-23 01:57:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084793005/20001

[commit-bot: I haz the power, 2015-04-23 02:01:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 02:01:28]

Presubmit check for 1084793005-20001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit ERRORS **
tests/masters_test.py (0.53s) failed
ERROR:root:Found unexpected master Chromium on port 8010


Presubmit checks took 214.0s to calculate.

[Dirk Pranke, 2015-04-23 02:05:14]

Committed patchset #2 (id:20001) manually as 294955.