Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json

Issue 1084793005: Flip remaining GN bots to use MB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: fix lint warning Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json
diff --git a/scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json b/scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json
index 40f1bff05d85c397114177fd851a519fb270775e..89446c97ef460ddcb91beb1f180f7e56ecaf5a7d 100644
--- a/scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json
+++ b/scripts/slave/recipes/chromium_gn.expected/full_client_v8_V8_Linux_GN.json
@@ -75,13 +75,39 @@
"cmd": [
"python",
"-u",
- "[DEPOT_TOOLS]/gn.py",
- "--root=[SLAVE_BUILD]/src",
+ "[SLAVE_BUILD]/src/tools/mb/mb.py",
"gen",
- "//out/Release",
- "--args=is_debug=false target_cpu=\"x64\" use_goma=true goma_dir=\"[BUILD]/goma\""
+ "-v",
+ "-m",
+ "client.v8",
+ "-b",
+ "V8 Linux GN",
+ "--goma-dir",
+ "[BUILD]/goma",
+ "//out/Release"
],
- "name": "gn"
+ "name": "mb gen"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport shutil\nimport sys\nshutil.copy(sys.argv[1], sys.argv[2])\n",
+ "[SLAVE_BUILD]/src/testing/buildbot/client.v8.json",
+ "/path/to/tmp/json"
+ ],
+ "name": "read test spec",
+ "~followup_annotations": [
+ "@@@STEP_TEXT@path: [SLAVE_BUILD]/src/testing/buildbot/client.v8.json@@@",
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"V8 Linux GN\": {@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"gtest_tests\": [@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"base_unittests\"@@@",
+ "@@@STEP_LOG_LINE@json.output@ ]@@@",
+ "@@@STEP_LOG_LINE@json.output@ }@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
},
{
"cmd": [
@@ -99,6 +125,7 @@
"--goma-dir",
"[BUILD]/goma",
"--",
+ "base_unittests",
"all"
],
"name": "compile"
@@ -113,24 +140,5 @@
"//out/Release"
],
"name": "gn check"
- },
- {
- "cmd": [
- "python",
- "-u",
- "[BUILD]/scripts/slave/runtest.py",
- "--target",
- "Release",
- "--no-xvfb",
- "--factory-properties",
- "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8 Linux GN\", \"buildnumber\": 571, \"mastername\": \"client.v8\", \"recipe\": \"chromium_gn\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
- "--build-properties",
- "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"V8 Linux GN\", \"buildnumber\": 571, \"mastername\": \"client.v8\", \"recipe\": \"chromium_gn\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
- "--builder-name=V8 Linux GN",
- "--slave-name=TestSlavename",
- "--build-number=571",
- "gn_unittests"
- ],
- "name": "gn_unittests"
}
]

Powered by Google App Engine
This is Rietveld 408576698