Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html

Issue 1084683003: Merge the value of the push subscription id into the endpoint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html
diff --git a/LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html b/LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html
index 79ee05f5ce9325b8ecd274d5cb72aa67445c2bda..2c6d49a159b69a2a5b94441dd13291fc1e81a23e 100644
--- a/LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html
+++ b/LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html
@@ -31,10 +31,15 @@ async_test(function(test) {
assert_will_be_idl_attribute(pushSubscription, 'endpoint');
assert_equals(typeof pushSubscription.endpoint, 'string');
+
+ // The |subscriptionId| attribute is being deprecated, and its value
+ // is now the last part of the |endpoint| attribute.
+ assert_true(pushSubscription.endpoint.endsWith(pushSubscription.subscriptionId));
+
try {
- var endpointUrl = new URL(pushSubscription.endpoint);
+ var endpointUrl = new URL(pushSubscription.endpoint);
} catch(e) {
- assert_unreached('Constructing a URL from the endpoint should not throw.');
+ assert_unreached('Constructing a URL from the endpoint should not throw.');
}
return service_worker_unregister_and_done(test, workerScope);
« no previous file with comments | « no previous file | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698