[Password manager tests automation] Adds an ability to specify test_case which should be run.

[Password manager tests automation] Adds an ability to specify test_case which should be run.

This CL in a step in a direction of making it possible to run one test-case for all websites, then another one for all websites.

BUG=369521
R=vabr@chromium.org

Committed: https://crrev.com/3456666edb5ec8081fc453f03f1b5cb3053124b5
Cr-Commit-Position: refs/heads/master@{#325621}

[melandory, 2015-04-13 14:58:15]

Hi Vaclav,

review this CL, please.

[vabr (Chromium), 2015-04-13 15:26:21]

Thanks, Tanja, LGTM with comments.

Could you please also correct the typos in the title + summary (sability and
shooul).

This is for making it possible to run one test-case for all websites, then
another one for all websites, etc., right?

Cheers,
Vaclav

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
File components/test/data/password_manager/automated_tests/environment.py
(right):

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
components/test/data/password_manager/automated_tests/environment.py:274:
test_case_name: A test name which is a method of WebsiteTest.
What do you think about requiring that the method name ends with "Test", as a
(weak) guard against accidents?

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
File components/test/data/password_manager/automated_tests/tests.py (right):

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
components/test/data/password_manager/automated_tests/tests.py:572: #
TODO(melandory): Think about supporting test case specifying on website
I'm not sure I understand what you want to think about. Could you please
explain?

[melandory, 2015-04-14 07:01:23]

On 2015/04/13 15:26:21, vabr (Chromium) wrote:
> Thanks, Tanja, LGTM with comments.
> 
> Could you please also correct the typos in the title + summary (sability and
> shooul).
> 
> This is for making it possible to run one test-case for all websites, then
> another one for all websites, etc., right?
Not this CL by itself. It's just step in this direction.
> 
> Cheers,
> Vaclav
> 
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> File components/test/data/password_manager/automated_tests/environment.py
> (right):
> 
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> components/test/data/password_manager/automated_tests/environment.py:274:
> test_case_name: A test name which is a method of WebsiteTest.
> What do you think about requiring that the method name ends with "Test", as a
> (weak) guard against accidents?
> 
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> File components/test/data/password_manager/automated_tests/tests.py (right):
> 
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> components/test/data/password_manager/automated_tests/tests.py:572: #
> TODO(melandory): Think about supporting test case specifying on website
> I'm not sure I understand what you want to think about. Could you please
> explain?

[vabr (Chromium), 2015-04-14 07:19:21]

On 2015/04/14 07:01:23, melandory wrote:
> On 2015/04/13 15:26:21, vabr (Chromium) wrote:
> > Thanks, Tanja, LGTM with comments.
> > 
> > Could you please also correct the typos in the title + summary (sability and
> > shooul).
> > 
> > This is for making it possible to run one test-case for all websites, then
> > another one for all websites, etc., right?
> Not this CL by itself. It's just step in this direction.
Yes, that's what I meant. It might be helpful to extend the CL description with
this motivation. Up to you, though.

Cheers,
Vaclav

> > 
> > Cheers,
> > Vaclav
> > 
> >
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> > File components/test/data/password_manager/automated_tests/environment.py
> > (right):
> > 
> >
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> > components/test/data/password_manager/automated_tests/environment.py:274:
> > test_case_name: A test name which is a method of WebsiteTest.
> > What do you think about requiring that the method name ends with "Test", as
a
> > (weak) guard against accidents?
> > 
> >
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> > File components/test/data/password_manager/automated_tests/tests.py (right):
> > 
> >
>
https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
> > components/test/data/password_manager/automated_tests/tests.py:572: #
> > TODO(melandory): Think about supporting test case specifying on website
> > I'm not sure I understand what you want to think about. Could you please
> > explain?

[melandory, 2015-04-14 07:22:36]

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
File components/test/data/password_manager/automated_tests/environment.py
(right):

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
components/test/data/password_manager/automated_tests/environment.py:274:
test_case_name: A test name which is a method of WebsiteTest.
On 2015/04/13 15:26:20, vabr (Chromium) wrote:
> What do you think about requiring that the method name ends with "Test", as a
> (weak) guard against accidents?

I was thinking of implementing a decorator which will add a test case name to a
list of available test cases on the fly (I need to deal with another CL I'm
preparing before starting this code). And when we have list of available test
cases, then we can check if test_case_name is one of them.

I'll add a TODO.

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
File components/test/data/password_manager/automated_tests/tests.py (right):

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
components/test/data/password_manager/automated_tests/tests.py:572: #
TODO(melandory): Think about supporting test case specifying on website
On 2015/04/13 15:26:20, vabr (Chromium) wrote:
> I'm not sure I understand what you want to think about. Could you please
> explain?

Hm, actually this todo doesn't belong here. And probably not needed at all.
Sorry for noise.

[vabr (Chromium), 2015-04-14 07:30:22]

LGTM, thanks!
Vaclav

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
File components/test/data/password_manager/automated_tests/environment.py
(right):

https://codereview.chromium.org/1084553003/diff/20001/components/test/data/pa...
components/test/data/password_manager/automated_tests/environment.py:274:
test_case_name: A test name which is a method of WebsiteTest.
On 2015/04/14 07:22:36, melandory wrote:
> On 2015/04/13 15:26:20, vabr (Chromium) wrote:
> > What do you think about requiring that the method name ends with "Test", as
a
> > (weak) guard against accidents?
> 
> I was thinking of implementing a decorator which will add a test case name to
a
> list of available test cases on the fly (I need to deal with another CL I'm
> preparing before starting this code). And when we have list of available test
> cases, then we can check if test_case_name is one of them.
> 
> I'll add a TODO.

Acknowledged.

[melandory, 2015-04-17 09:55:28]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-04-17 09:55:29]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1084553003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-17 09:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084553003/60001

[commit-bot: I haz the power, 2015-04-17 09:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-17 09:59:50]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[melandory, 2015-04-17 11:47:18]

Patchset #4 (id:60001) has been deleted

[melandory, 2015-04-17 11:47:42]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-04-17 11:47:42]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1084553003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-17 11:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084553003/80001

[commit-bot: I haz the power, 2015-04-17 12:38:53]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-04-17 12:39:42]

Patchset 4 (id:??) landed as
https://crrev.com/3456666edb5ec8081fc453f03f1b5cb3053124b5
Cr-Commit-Position: refs/heads/master@{#325621}