[Password manager tests automation] Adds an ability to specify test_case which should be run.

components/test/data/password_manager/automated_tests/environment.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """The testing Environment class.
 
 It holds the WebsiteTest instances, provides them with credentials,
 provides clean browser environment, runs the tests, and gathers the
 results.
 """
@@ skipping 243 matching lines @@
           string_should_show_up):
         raise Exception(error)
     finally:
       self.driver.switch_to_window(self.website_window)
 
   def DeleteCookies(self):
     """Deletes cookies via the settings page."""
 
     self._ClearDataForCheckbox("#delete-cookies-checkbox")
 
-  def RunTestsOnSites(self, test_type):
+  def RunTestsOnSites(self, test_case_name):
     """Runs the specified test on the known websites.
 
     Also saves the test results in the environment. Note that test types
     differ in their requirements on whether the save password prompt
     should be displayed. Make sure that such requirements are consistent
     with the enable_automatic_password_saving argument passed to |self|
     on construction.
 
     Args:
-      test_type: A test identifier understood by WebsiteTest.run_test().
+      test_case_name: A test name which is a method of WebsiteTest.

[vabr (Chromium), 2015/04/13 15:26:20]

What do you think about requiring that the method name ends with "Test", as a
(weak) guard against accidents?

[melandory, 2015/04/14 07:22:36]

I was thinking of implementing a decorator which will add a test case name to a
list of available test cases on the fly (I need to deal with another CL I'm
preparing before starting this code). And when we have list of available test
cases, then we can check if test_case_name is one of them.

I'll add a TODO.

[vabr (Chromium), 2015/04/14 07:30:22]

Acknowledged.

     """
 
     self.DeleteCookies()
     self._ClearDataForCheckbox("#delete-passwords-checkbox")
     self._EnablePasswordSaving()
 
     for websitetest in self.websitetests:
       successful = True
       error = ""
       try:
-        websitetest.RunTest(test_type)
+        getattr(websitetest, test_case_name)()
       except Exception as e:
         successful = False
         error = e.message
       self.tests_results.append(
-          (websitetest.name, test_type, successful, error))
+          (websitetest.name, test_case_name, successful, error))
 
   def Quit(self):
     """Shuts down the driver."""
 
     self.driver.quit()