Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1084533003: Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. (patchset #10 id:180001 of https://codereview.chromium.org/1063513003/) Reason for revert: [sheriff] Breaks nosnap debug: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%201/builds/156 Original issue's description: > [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. > > Uses lazy deoptimization and code dependencies to introduce loads > from property cells and also to promote globals to constants. > > R=mstarzinger@chromium.org > BUG= > > Committed: https://crrev.com/aae4a62d07e839455b1d0ad4fa512cc5d48a1a68 > Cr-Commit-Position: refs/heads/master@{#28057} TBR=mstarzinger@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/fbf300802f0b2dd3dcaca92790709a28216be859 Cr-Commit-Position: refs/heads/master@{#28063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -564 lines) Patch
M src/compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/js-type-feedback.h View 4 chunks +2 lines, -10 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 6 chunks +16 lines, -100 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 3 chunks +0 lines, -9 lines 0 comments Download
D test/mjsunit/compiler/global-delete.js View 1 chunk +0 lines, -73 lines 0 comments Download
D test/mjsunit/compiler/global-var-delete.js View 1 chunk +0 lines, -73 lines 0 comments Download
D test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +0 lines, -277 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer.
5 years, 8 months ago (2015-04-27 10:07:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084533003/1
5 years, 8 months ago (2015-04-27 10:07:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 10:07:34 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 10:07:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf300802f0b2dd3dcaca92790709a28216be859
Cr-Commit-Position: refs/heads/master@{#28063}

Powered by Google App Engine
This is Rietveld 408576698