Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Side by Side Diff: src/compiler/pipeline.cc

Issue 1084533003: Revert of [turbofan] Optimize loads from the global object in JSTypeFeedbackSpecializer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/platform/elapsed-timer.h" 10 #include "src/base/platform/elapsed-timer.h"
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 static const char* phase_name() { return "type feedback specializing"; } 535 static const char* phase_name() { return "type feedback specializing"; }
536 536
537 void Run(PipelineData* data, Zone* temp_zone) { 537 void Run(PipelineData* data, Zone* temp_zone) {
538 SourcePositionTable::Scope pos(data->source_positions(), 538 SourcePositionTable::Scope pos(data->source_positions(),
539 SourcePosition::Unknown()); 539 SourcePosition::Unknown());
540 Handle<Context> native_context(data->info()->context()->native_context()); 540 Handle<Context> native_context(data->info()->context()->native_context());
541 TypeFeedbackOracle oracle(data->isolate(), temp_zone, 541 TypeFeedbackOracle oracle(data->isolate(), temp_zone,
542 data->info()->unoptimized_code(), 542 data->info()->unoptimized_code(),
543 data->info()->feedback_vector(), native_context); 543 data->info()->feedback_vector(), native_context);
544 GraphReducer graph_reducer(data->graph(), temp_zone); 544 GraphReducer graph_reducer(data->graph(), temp_zone);
545 Handle<GlobalObject> global_object = Handle<GlobalObject>::null(); 545 JSTypeFeedbackSpecializer specializer(data->jsgraph(),
546 if (data->info()->has_global_object()) { 546 data->js_type_feedback(), &oracle);
547 global_object =
548 Handle<GlobalObject>(data->info()->global_object(), data->isolate());
549 }
550 // TODO(titzer): introduce a specialization mode/flags enum to control
551 // specializing to the global object here.
552 JSTypeFeedbackSpecializer specializer(
553 data->jsgraph(), data->js_type_feedback(), &oracle, global_object,
554 data->info()->dependencies());
555 AddReducer(data, &graph_reducer, &specializer); 547 AddReducer(data, &graph_reducer, &specializer);
556 graph_reducer.ReduceGraph(); 548 graph_reducer.ReduceGraph();
557 } 549 }
558 }; 550 };
559 551
560 552
561 struct TypedLoweringPhase { 553 struct TypedLoweringPhase {
562 static const char* phase_name() { return "typed lowering"; } 554 static const char* phase_name() { return "typed lowering"; }
563 555
564 void Run(PipelineData* data, Zone* temp_zone) { 556 void Run(PipelineData* data, Zone* temp_zone) {
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
1315 tcf << AsC1VRegisterAllocationData("CodeGen", 1307 tcf << AsC1VRegisterAllocationData("CodeGen",
1316 data->register_allocation_data()); 1308 data->register_allocation_data());
1317 } 1309 }
1318 1310
1319 data->DeleteRegisterAllocationZone(); 1311 data->DeleteRegisterAllocationZone();
1320 } 1312 }
1321 1313
1322 } // namespace compiler 1314 } // namespace compiler
1323 } // namespace internal 1315 } // namespace internal
1324 } // namespace v8 1316 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-type-feedback.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698