Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1084323007: Update {virtual,override} to follow C++11 style in ipc. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in ipc. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/d60f71748cc8d3fdfa30811b6896df6e4113d15a Cr-Commit-Position: refs/heads/master@{#326544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M ipc/ipc_channel_nacl.h View 2 chunks +12 lines, -12 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
tsepez: please review! thanks.
5 years, 8 months ago (2015-04-23 14:05:51 UTC) #2
Tom Sepez
On 2015/04/23 14:05:51, ncarter wrote: > tsepez: please review! thanks. LGTM. Thanks for the cleanup.
5 years, 8 months ago (2015-04-23 16:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084323007/1
5 years, 8 months ago (2015-04-23 16:38:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 16:42:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:44:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d60f71748cc8d3fdfa30811b6896df6e4113d15a
Cr-Commit-Position: refs/heads/master@{#326544}

Powered by Google App Engine
This is Rietveld 408576698