Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: ipc/mojo/ipc_channel_mojo_unittest.cc

Issue 1084323007: Update {virtual,override} to follow C++11 style in ipc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_channel_nacl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/mojo/ipc_channel_mojo.h" 5 #include "ipc/mojo/ipc_channel_mojo.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 } 544 }
545 545
546 MULTIPROCESS_IPC_TEST_CLIENT_MAIN(ParamTraitInvalidMessagePipeClient) { 546 MULTIPROCESS_IPC_TEST_CLIENT_MAIN(ParamTraitInvalidMessagePipeClient) {
547 ParamTraitMessagePipeClient(false, "ParamTraitInvalidMessagePipeClient"); 547 ParamTraitMessagePipeClient(false, "ParamTraitInvalidMessagePipeClient");
548 return 0; 548 return 0;
549 } 549 }
550 550
551 #if defined(OS_WIN) 551 #if defined(OS_WIN)
552 class IPCChannelMojoDeadHandleTest : public IPCChannelMojoTestBase { 552 class IPCChannelMojoDeadHandleTest : public IPCChannelMojoTestBase {
553 protected: 553 protected:
554 virtual scoped_ptr<IPC::ChannelFactory> CreateChannelFactory( 554 scoped_ptr<IPC::ChannelFactory> CreateChannelFactory(
555 const IPC::ChannelHandle& handle, 555 const IPC::ChannelHandle& handle,
556 base::SequencedTaskRunner* runner) override { 556 base::SequencedTaskRunner* runner) override {
557 host_.reset(new IPC::ChannelMojoHost(task_runner())); 557 host_.reset(new IPC::ChannelMojoHost(task_runner()));
558 return IPC::ChannelMojo::CreateServerFactory(host_->channel_delegate(), 558 return IPC::ChannelMojo::CreateServerFactory(host_->channel_delegate(),
559 task_runner(), handle); 559 task_runner(), handle);
560 } 560 }
561 561
562 virtual bool DidStartClient() override { 562 bool DidStartClient() override {
563 IPCTestBase::DidStartClient(); 563 IPCTestBase::DidStartClient();
564 const base::ProcessHandle client = client_process().Handle(); 564 const base::ProcessHandle client = client_process().Handle();
565 // Forces GetFileHandleForProcess() fail. It happens occasionally 565 // Forces GetFileHandleForProcess() fail. It happens occasionally
566 // in production, so we should exercise it somehow. 566 // in production, so we should exercise it somehow.
567 // TODO(morrita): figure out how to safely test this. See crbug.com/464109. 567 // TODO(morrita): figure out how to safely test this. See crbug.com/464109.
568 // ::CloseHandle(client); 568 // ::CloseHandle(client);
569 host_->OnClientLaunched(client); 569 host_->OnClientLaunched(client);
570 return true; 570 return true;
571 } 571 }
572 572
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 base::MessageLoop::current()->Run(); 774 base::MessageLoop::current()->Run();
775 775
776 client.Close(); 776 client.Close();
777 777
778 return 0; 778 return 0;
779 } 779 }
780 780
781 #endif // OS_LINUX 781 #endif // OS_LINUX
782 782
783 } // namespace 783 } // namespace
OLDNEW
« no previous file with comments | « ipc/ipc_channel_nacl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698