Adding status to swap complete

ui/gl/gl_surface.cc

Index: ui/gl/gl_surface.cc
diff --git a/ui/gl/gl_surface.cc b/ui/gl/gl_surface.cc
index 47690924fa7d4f06da4cc1f033f23823126b8ddb..bb440ddc32537ca69560f09e7f5837eca3c36d02 100644
--- a/ui/gl/gl_surface.cc
+++ b/ui/gl/gl_surface.cc
@@ -12,6 +12,7 @@
 #include "base/logging.h"
 #include "base/threading/thread_local.h"
 #include "base/trace_event/trace_event.h"
+#include "ui/gfx/swap_result.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_switches.h"
@@ -195,7 +196,7 @@ unsigned int GLSurface::GetBackingFrameBufferObject() {
 bool GLSurface::SwapBuffersAsync(const SwapCompletionCallback& callback) {
   DCHECK(!IsSurfaceless());
   bool success = SwapBuffers();
-  callback.Run();
+  callback.Run(SwapAck);

[piman, 2015/05/13 16:53:16]

SwapAck seems wrong if !success. Should SwapBuffers return a SwapAck instead?

[achaulk, 2015/05/14 18:15:46]

Ah, yeah I just changed it to switch off of the bool

[piman, 2015/05/14 19:08:19]

Can you change the return value of SwapBuffers instead? Is there a fundamental
reason why the sync and async versions should differ?

[achaulk, 2015/05/14 20:38:26]

Done.

   return success;
 }
 
@@ -209,7 +210,7 @@ bool GLSurface::PostSubBufferAsync(int x,
                                    int height,
                                    const SwapCompletionCallback& callback) {
   bool success = PostSubBuffer(x, y, width, height);
-  callback.Run();
+  callback.Run(SwapAck);
   return success;
 }