[Password Generation] Fix bug where generation would never trigger on iframes

[Password Generation] Fix bug where generation would never trigger on iframes

This also fixes a long standing flake in PasswordGenerationInteractiveTest
and adds a new test.

BUG=477147
Committed: https://crrev.com/7db5401bee32a5115268984f8461c30348346581
Cr-Commit-Position: refs/heads/master@{#326655}

[Garrett Casto, 2015-04-14 23:02:09]

The CQ bit was checked by gcasto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-14 23:03:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084063002/1

[commit-bot: I haz the power, 2015-04-14 23:12:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 23:12:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Garrett Casto, 2015-04-15 00:17:12]

The CQ bit was checked by gcasto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-15 00:18:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084063002/20001

[Garrett Casto, 2015-04-15 00:20:28]

gcasto@chromium.org changed reviewers:
+ vabr@chromium.org

[commit-bot: I haz the power, 2015-04-15 00:28:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-15 00:28:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Garrett Casto, 2015-04-15 07:11:37]

On 2015/04/15 00:28:27, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hmm, apparently something is still wrong with the tests. I'll take a look
tomorrow.

[vabr (Chromium), 2015-04-15 07:49:43]

The fix and the new test LGTM. Good luck with fixing the flakes! :)

Cheers,
Vaclav

[Garrett Casto, 2015-04-22 23:48:50]

So unfortunately fixing the tests is harder than I thought. The function that I
tried to use before is apparently just broken and all the tests that currently
rely on it are flaky/disabled. I'm still actively working with people to fix
that, but I don't want to hold up this CL as it should really be merged into
M43.

[vabr (Chromium), 2015-04-23 09:14:36]

On 2015/04/22 23:48:50, Garrett Casto wrote:
> So unfortunately fixing the tests is harder than I thought. The function that
I
> tried to use before is apparently just broken and all the tests that currently
> rely on it are flaky/disabled. I'm still actively working with people to fix
> that, but I don't want to hold up this CL as it should really be merged into
> M43.

Sounds good to replace the test with a TODO, then. What you did in patch set 3
provides enough information, so that one LGTM.

Thanks!
Vaclav

[Garrett Casto, 2015-04-23 21:30:00]

The CQ bit was checked by gcasto@chromium.org

[commit-bot: I haz the power, 2015-04-23 21:30:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1084063002/40001

[commit-bot: I haz the power, 2015-04-23 21:44:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-23 21:44:57]

Patchset 3 (id:??) landed as
https://crrev.com/7db5401bee32a5115268984f8461c30348346581
Cr-Commit-Position: refs/heads/master@{#326655}