[Password Generation] Fix bug where generation would never trigger on iframes

chrome/browser/password_manager/password_generation_interactive_uitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_observer.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 114 matching lines @@
   }
 
   bool EditingPopupShowing() {
     return observer_.popup_showing() && !observer_.password_visible();
   }
 
  private:
   TestPopupObserver observer_;
 };
 
-#if defined(USE_AURA)
-// Enabled on these platforms.
-// Disabled due to flakiness, see http://crbug.com/407998
-#define MAYBE_PopupShownAndPasswordSelected \
-  DISABLED_PopupShownAndPasswordSelected
-#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
-#define MAYBE_PopupShownAndDismissedByScrolling \
-  DISABLED_PopupShownAndDismissedByScrolling
-#else
-// Popup not enabled for these platforms yet.
-#define MAYBE_PopupShownAndPasswordSelected \
-  DISABLED_PopupShownAndPasswordSelected
-#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
-#define MAYBE_PopupShownAndDismissedByScrolling \
-  DISABLED_PopupShownAndDismissedByScrolling
-#endif
-
+// Disabled due to flakiness due to resizes, see http://crbug.com/407998.
 IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
-                       MAYBE_PopupShownAndPasswordSelected) {
+                       DISABLED_PopupShownAndPasswordSelected) {
   FocusPasswordField();
   EXPECT_TRUE(GenerationPopupShowing());
   SendKeyToPopup(ui::VKEY_DOWN);
   SendKeyToPopup(ui::VKEY_RETURN);
 
   // Selecting the password should fill the field and move focus to the
   // submit button.
   EXPECT_FALSE(GetFieldValue("password_field").empty());
   EXPECT_FALSE(GenerationPopupShowing());
   EXPECT_FALSE(EditingPopupShowing());
   EXPECT_EQ("input_submit_button", GetFocusedElement());
 
   // Re-focusing the password field should show the editing popup.
   FocusPasswordField();
   EXPECT_TRUE(EditingPopupShowing());
 }
 
+// Disabled due to flakiness due to resizes, see http://crbug.com/407998.
 IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
-                       MAYBE_PopupShownAndDismissed) {
+                       DISABLED_PopupShownAndDismissed) {
   FocusPasswordField();
   EXPECT_TRUE(GenerationPopupShowing());
 
   SendKeyToPopup(ui::VKEY_ESCAPE);
 
   // Popup is dismissed.
   EXPECT_FALSE(GenerationPopupShowing());
 }
 
+// Disabled due to flakiness due to resizes, see http://crbug.com/407998.
 IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
-                       MAYBE_PopupShownAndDismissedByScrolling) {
+                       DISABLED_PopupShownAndDismissedByScrolling) {
   FocusPasswordField();
   EXPECT_TRUE(GenerationPopupShowing());
 
   ASSERT_TRUE(content::ExecuteScript(GetRenderViewHost(),
                                      "window.scrollTo(100, 0);"));
 
   EXPECT_FALSE(GenerationPopupShowing());
 }
+
+// Disabled due to flakiness due to resizes, see http://crbug.com/407998.
+IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
+                       DISABLED_GenerationTriggeredInIFrame) {
+  GURL url = embedded_test_server()->GetURL(
+      "/password/framed_signup_form.html");
+  ui_test_utils::NavigateToURL(browser(), url);
+
+  std::string focus_script =
+      "var frame = document.getElementById('signup_iframe');"
+      "var frame_doc = frame.contentDocument;"
+      "frame_doc.getElementById('password_field').focus();";
+
+  ASSERT_TRUE(content::ExecuteScript(GetRenderViewHost(), focus_script));
+  EXPECT_TRUE(GenerationPopupShowing());
+}