Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/parser.cc

Issue 1083953002: Fix FormalParameterErrorLocations member names (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/preparser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index a6526b8d1a2e490e3a34fb2bd968204d4835a59a..2e7c79d1865a06c2907b722285061b2cdb38f30d 100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -3720,12 +3720,12 @@ void ParserTraits::RecordArrowFunctionParameter(
return;
}
- if (!error_locs->eval_or_arguments_.IsValid() && IsEvalOrArguments(raw_name))
- error_locs->eval_or_arguments_ = param_location;
- if (!error_locs->reserved_.IsValid() && IsFutureStrictReserved(raw_name))
- error_locs->reserved_ = param_location;
- if (!error_locs->undefined_.IsValid() && IsUndefined(raw_name))
- error_locs->undefined_ = param_location;
+ if (!error_locs->eval_or_arguments.IsValid() && IsEvalOrArguments(raw_name))
+ error_locs->eval_or_arguments = param_location;
+ if (!error_locs->reserved.IsValid() && IsFutureStrictReserved(raw_name))
+ error_locs->reserved = param_location;
+ if (!error_locs->undefined.IsValid() && IsUndefined(raw_name))
+ error_locs->undefined = param_location;
// TODO(wingo): Fix quadratic check. (Scope::IsDeclaredParameter has the same
// issue.)
@@ -3955,7 +3955,7 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
scope->set_start_position(start_position);
num_parameters = DeclareFormalParameters(params, scope_, has_rest);
- if (error_locs.duplicate_.IsValid()) {
+ if (error_locs.duplicate.IsValid()) {
duplicate_parameters = FunctionLiteral::kHasDuplicateParameters;
}
« no previous file with comments | « no previous file | src/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698