Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1083923006: Revert of Convert Color32 code to perfect blend. (Closed)

Created:
5 years, 8 months ago by mtklein
Modified:
5 years, 8 months ago
Reviewers:
f(malita), mtklein_C, reed1
CC:
reviews_skia.org, caryclark
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Convert Color32 code to perfect blend. (patchset #6 id:100001 of https://codereview.chromium.org/1098913002/) Reason for revert: Xfermode_SrcOver not looking encouraging. Up to 50% regressions. https://perf.skia.org/#3242 Original issue's description: > Convert Color32 code to perfect blend. > > Before we commit to blend_256_round_alt, let's make sure blend_perfect is > really slower in practice (i.e. regresses on perf.skia.org). > > blend_perfect is really the most desirable algorithm if we can afford it. Not > only is it correct, but it's easy to think about and break into correct pieces: > for instance, its div255() doesn't require any coordination with the multiply. > > This looks like a 30% hit according to microbenches. That said, microbenches > said my previous change would be a 20-25% perf improvement, but it didn't end > up showing a significant effect at a high level. > > As for correctness, I see a bunch of off-by-1 compared to blend_256_round_alt > (exactly what we'd expect), and one off-by-3 in a GM that looks like it has a > bunch of overdraw. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/61221e7f87a99765b0e034020e06bb018e2a08c2 TBR=reed@google.com,fmalita@chromium.org,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a4a0aeb74808a0860f3e94588d0ceb0da9fed386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -42 lines) Patch
M src/core/SkBlitRow_D32.cpp View 2 chunks +15 lines, -12 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 1 chunk +27 lines, -16 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +22 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Convert Color32 code to perfect blend.
5 years, 8 months ago (2015-04-21 15:09:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083923006/1
5 years, 8 months ago (2015-04-21 15:09:25 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 15:09:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a4a0aeb74808a0860f3e94588d0ceb0da9fed386

Powered by Google App Engine
This is Rietveld 408576698