The default for x1, y1 and y2 is 0% for LinearGradient

The default for x1, y1 and y2 is 0% for LinearGradient

As per the spec,
If the x1|y1|y2 attribute is not specified, the effect is as if a value of "0%" were specified

BUG=476861
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193702

[Shanmuga Pandi, 2015-04-14 09:20:55]

shanmuga.m@samsung.com changed reviewers:
+ ed@opera.com, fs@opera.com, pdr@chromium.org

[Shanmuga Pandi, 2015-04-14 09:20:55]

Please review it. Thanks

[Erik Dahlström (inactive), 2015-04-14 09:27:46]

lgtm w/nit

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
File LayoutTests/fast/svg/linear-gradient-default-length.html (right):

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:12: function
testLengthValue(result,expected, testcase) {
nit: add a space after the comma

[Shanmuga Pandi, 2015-04-14 09:30:17]

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
File LayoutTests/fast/svg/linear-gradient-default-length.html (right):

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:12: function
testLengthValue(result,expected, testcase) {
On 2015/04/14 09:27:46, Erik Dahlström wrote:
> nit: add a space after the comma

Done.

[Shanmuga Pandi, 2015-04-14 10:07:18]

The CQ bit was checked by shanmuga.m@samsung.com

[Shanmuga Pandi, 2015-04-14 10:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ed@opera.com
Link to the patchset: https://codereview.chromium.org/1083893002/#ps40001
(title: "fixed nits")

[commit-bot: I haz the power, 2015-04-14 10:07:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083893002/40001

[commit-bot: I haz the power, 2015-04-14 10:19:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 10:19:53]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[fs, 2015-04-14 10:24:15]

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
File LayoutTests/fast/svg/linear-gradient-default-length.html (right):

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:2: <title>SVGlength
tests</title>
Could be more specific. Maybe something like: "SVGLinearGradientElement
coordinate defaults" ?

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:5: <div
id="testcontainer">
Useful for?

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:6: <svg width="1"
height="1" visibility="hidden">
These attributes doesn't seem useful for anything. height=0 or so might suffice
to make it invisible.

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:10: <div id=log></div>
Not needed.

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:15: }, testcase);
With a better <title> you might do: document.title+', '+testcase here (and drop
the "linearGradient." bit)

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:18:
testLengthValue(document.querySelector("#lg").x1.baseVal.valueAsString, "0%",
"linearGradient.x1");
Maybe first do:

var linearGradient = document.querySelector("#lg");

to reduce boilerplate a bit.

[Shanmuga Pandi, 2015-04-14 10:41:38]

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
File LayoutTests/fast/svg/linear-gradient-default-length.html (right):

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:2: <title>SVGlength
tests</title>
On 2015/04/14 10:24:15, fs wrote:
> Could be more specific. Maybe something like: "SVGLinearGradientElement
> coordinate defaults" ?

Done.

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:5: <div
id="testcontainer">
On 2015/04/14 10:24:15, fs wrote:
> Useful for?

Removed

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:6: <svg width="1"
height="1" visibility="hidden">
On 2015/04/14 10:24:15, fs wrote:
> These attributes doesn't seem useful for anything. height=0 or so might
suffice
> to make it invisible.

Removed unneeded attributes

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:10: <div id=log></div>
On 2015/04/14 10:24:15, fs wrote:
> Not needed.

Acknowledged.

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:15: }, testcase);
On 2015/04/14 10:24:15, fs wrote:
> With a better <title> you might do: document.title+', '+testcase here (and
drop
> the "linearGradient." bit)

Done.

https://codereview.chromium.org/1083893002/diff/20001/LayoutTests/fast/svg/li...
LayoutTests/fast/svg/linear-gradient-default-length.html:18:
testLengthValue(document.querySelector("#lg").x1.baseVal.valueAsString, "0%",
"linearGradient.x1");
On 2015/04/14 10:24:15, fs wrote:
> Maybe first do:
> 
> var linearGradient = document.querySelector("#lg");
> 
> to reduce boilerplate a bit.

Done.

[fs, 2015-04-14 12:36:37]

The CQ bit was checked by fs@opera.com

[fs, 2015-04-14 12:36:38]

lgtm

[fs, 2015-04-14 12:36:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ed@opera.com
Link to the patchset: https://codereview.chromium.org/1083893002/#ps60001
(title: "Align with review comments")

[commit-bot: I haz the power, 2015-04-14 12:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1083893002/60001

[commit-bot: I haz the power, 2015-04-14 14:03:22]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193702