LayoutTests/fast/svg/linear-gradient-default-length.html - Issue 1083893002: The default for x1, y1 and y2 is 0% for LinearGradient

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/svg/linear-gradient-default-length.html

Issue 1083893002: The default for x1, y1 and y2 is 0% for LinearGradient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: small nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>SVGlength tests</title>
	fs 2015/04/14 10:24:15 Could be more specific. Maybe something like: "SVG Could be more specific. Maybe something like: "SVGLinearGradientElement coordinate defaults" ? Shanmuga Pandi 2015/04/14 10:41:37 Done. Show quoted text On 2015/04/14 10:24:15, fs wrote: > Could be more specific. Maybe something like: "SVGLinearGradientElement > coordinate defaults" ? Done.
	3 <script src=../../resources/testharness.js></script>

	4 <script src=../../resources/testharnessreport.js></script>

	5 <div id="testcontainer">
	fs 2015/04/14 10:24:15 Useful for? Useful for? Shanmuga Pandi 2015/04/14 10:41:37 Removed Show quoted text On 2015/04/14 10:24:15, fs wrote: > Useful for? Removed
	6 <svg width="1" height="1" visibility="hidden">
	fs 2015/04/14 10:24:15 These attributes doesn't seem useful for anything. These attributes doesn't seem useful for anything. height=0 or so might suffice to make it invisible. Shanmuga Pandi 2015/04/14 10:41:37 Removed unneeded attributes Show quoted text On 2015/04/14 10:24:15, fs wrote: > These attributes doesn't seem useful for anything. height=0 or so might suffice > to make it invisible. Removed unneeded attributes
	7 <linearGradient id="lg"/>

	8 </svg>

	9 </div>

	10 <div id=log></div>
	fs 2015/04/14 10:24:15 Not needed. Not needed. Shanmuga Pandi 2015/04/14 10:41:37 Acknowledged. Show quoted text On 2015/04/14 10:24:15, fs wrote: > Not needed. Acknowledged.
	11 <script>

	12 function testLengthValue(result,expected, testcase) {
	Erik Dahlström (inactive) 2015/04/14 09:27:46 nit: add a space after the comma nit: add a space after the comma Shanmuga Pandi 2015/04/14 09:30:17 Done. Show quoted text On 2015/04/14 09:27:46, Erik Dahlström wrote: > nit: add a space after the comma Done.
	13 test(function() {

	14 assert_equals(result, expected);

	15 }, testcase);
	fs 2015/04/14 10:24:15 With a better <title> you might do: document.title With a better <title> you might do: document.title+', '+testcase here (and drop the "linearGradient." bit) Shanmuga Pandi 2015/04/14 10:41:37 Done. Show quoted text On 2015/04/14 10:24:15, fs wrote: > With a better <title> you might do: document.title+', '+testcase here (and drop > the "linearGradient." bit) Done.
	16 }

	17

	18 testLengthValue(document.querySelector("#lg").x1.baseVal.valueAsString, "0%", "l inearGradient.x1");
	fs 2015/04/14 10:24:15 Maybe first do: var linearGradient = document.que Maybe first do: var linearGradient = document.querySelector("#lg"); to reduce boilerplate a bit. Shanmuga Pandi 2015/04/14 10:41:37 Done. Show quoted text On 2015/04/14 10:24:15, fs wrote: > Maybe first do: > > var linearGradient = document.querySelector("#lg"); > > to reduce boilerplate a bit. Done.
	19 testLengthValue(document.querySelector("#lg").x2.baseVal.valueAsString, "100%", "linearGradient.x2");

	20 testLengthValue(document.querySelector("#lg").y1.baseVal.valueAsString, "0%", "l inearGradient.y1");

	21 testLengthValue(document.querySelector("#lg").y2.baseVal.valueAsString, "0%", "l inearGradient.y2");

	22 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/svg/SVGLinearGradientElement.cpp » ('j') | no next file with comments »