Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 108383002: Move Cursor to platform/ (Closed)

Created:
7 years ago by pilgrim_google
Modified:
7 years ago
Reviewers:
abarth-chromium
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, tommyw+watchlist_chromium.org, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, darin (slow to review)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add missing export macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -672 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.h View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/Cursor.h View 1 chunk +0 lines, -169 lines 0 comments Download
D Source/core/platform/Cursor.cpp View 1 chunk +0 lines, -446 lines 0 comments Download
M Source/core/platform/chromium/support/WebCursorInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +1 line, -1 line 0 comments Download
A + Source/platform/Cursor.h View 1 2 3 chunks +46 lines, -45 lines 0 comments Download
A + Source/platform/Cursor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
pilgrim_google
7 years ago (2013-12-06 15:36:19 UTC) #1
abarth-chromium
lgtm
7 years ago (2013-12-07 21:56:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/108383002/1
7 years ago (2013-12-07 21:56:38 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/page/ChromeClient.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-07 21:56:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/108383002/20001
7 years ago (2013-12-09 14:42:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=4927
7 years ago (2013-12-09 15:23:07 UTC) #6
pilgrim_google
On 2013/12/09 15:23:07, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-09 16:14:45 UTC) #7
pilgrim_google
On 2013/12/09 16:14:45, pilgrim_google wrote: > On 2013/12/09 15:23:07, I haz the power (commit-bot) wrote: ...
7 years ago (2013-12-09 16:15:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/108383002/40001
7 years ago (2013-12-09 16:24:03 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-09 17:46:35 UTC) #10
Message was sent while issue was closed.
Change committed as 163445

Powered by Google App Engine
This is Rietveld 408576698