Issue 10836195: Remove obsolete code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10836195: Remove obsolete code (Closed)

Created:
8 years, 4 months ago by joth

Modified:
8 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove obsolete code FindReplyACK could never have any effect, because queued_find_reply_message_ can only ever be NULL. BUG=83097 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151186

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -47 lines)			Patch
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/common/view_messages.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	3 chunks	+6 lines, -26 lines	0 comments	Download

Total messages: 4 (0 generated)

joth

Hi Antoine, would you take a look at this? As per the bug, AFAICT this ...

8 years, 4 months ago (2012-08-10 23:21:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/10836195/1

8 years, 4 months ago (2012-08-10 23:28:00 UTC) #3

Change committed as 151186