Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1083573002: Revert https://codereview.chromium.org/1060993003 (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert https://codereview.chromium.org/1060993003 Probably caused http://crbug.com/476408 I didn't revert the histogram changes since that file says "never remove anything here". BUG=476408 TBR=rdevlin.cronin Committed: https://chromium.googlesource.com/chromium/src/+/349f0c7e92cb5b32e8acb66cad6196bc437f3d91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -364 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 2 chunks +1 line, -23 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 7 chunks +3 lines, -85 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 4 chunks +55 lines, -61 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 2 chunks +0 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 3 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 8 chunks +94 lines, -22 lines 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 4 chunks +13 lines, -35 lines 0 comments Download
M extensions/browser/extension_function.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/closure_compiler/externs/developer_private.js View 49 chunks +1 line, -96 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
5 years, 8 months ago (2015-04-13 04:25:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083573002/1
5 years, 8 months ago (2015-04-13 04:25:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/349f0c7e92cb5b32e8acb66cad6196bc437f3d91 Cr-Commit-Position: refs/heads/master@{#324815}
5 years, 8 months ago (2015-04-13 04:36:56 UTC) #5
Nico
5 years, 8 months ago (2015-04-13 04:37:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
349f0c7e92cb5b32e8acb66cad6196bc437f3d91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698