Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1060993003: [Extensions UI] Use developerPrivate API for profile configuration (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Use developerPrivate API for profile configuration Transition the chrome://extensions page to use the developerPrivate API for getting data about a profile's configuration, and for updating that configuration (e.g. for developer mode). BUG=461039 Committed: https://crrev.com/b1e5d24b2a3b1bb95b4cbb83b752d775952c91cc Cr-Commit-Position: refs/heads/master@{#324726}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Ben's #

Total comments: 4

Patch Set 3 : Dan's #

Patch Set 4 : Latest master #

Patch Set 5 : Test Fix #

Total comments: 10

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -187 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 2 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 7 chunks +85 lines, -3 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 2 3 4 4 chunks +61 lines, -55 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 2 3 4 5 6 3 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 3 4 5 6 8 chunks +22 lines, -94 lines 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 4 chunks +35 lines, -13 lines 0 comments Download
M extensions/browser/extension_function.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/externs/developer_private.js View 1 49 chunks +96 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 39 (17 generated)
Devlin
Ben, mind taking a look at the C++?
5 years, 8 months ago (2015-04-07 23:17:49 UTC) #5
not at google - send to devlin
lgtm https://codereview.chromium.org/1060993003/diff/60001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/1060993003/diff/60001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode501 chrome/browser/extensions/api/developer_private/developer_private_api.cc:501: Profile* profile = Profile::FromBrowserContext(browser_context()); If you inherit from ...
5 years, 8 months ago (2015-04-08 17:12:02 UTC) #6
Devlin
https://codereview.chromium.org/1060993003/diff/60001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/1060993003/diff/60001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode501 chrome/browser/extensions/api/developer_private/developer_private_api.cc:501: Profile* profile = Profile::FromBrowserContext(browser_context()); On 2015/04/08 17:12:02, kalman wrote: ...
5 years, 8 months ago (2015-04-09 19:57:24 UTC) #7
Devlin
Dan, mind taking a look at *.js? (Lemme know if I'm overwhelming you and should ...
5 years, 8 months ago (2015-04-09 20:00:07 UTC) #10
Dan Beam
lgtm On 2015/04/09 20:00:07, Devlin wrote: > Dan, mind taking a look at *.js? (Lemme ...
5 years, 8 months ago (2015-04-10 02:48:06 UTC) #11
Devlin
https://codereview.chromium.org/1060993003/diff/100001/chrome/browser/resources/extensions/extensions.js File chrome/browser/resources/extensions/extensions.js (right): https://codereview.chromium.org/1060993003/diff/100001/chrome/browser/resources/extensions/extensions.js#newcode232 chrome/browser/resources/extensions/extensions.js:232: var supervised = profileInfo.isSupervised; On 2015/04/10 02:48:06, Dan Beam ...
5 years, 8 months ago (2015-04-10 16:30:39 UTC) #13
Devlin
Mark, mind checking histograms real quick?
5 years, 8 months ago (2015-04-10 16:30:56 UTC) #15
Mark P
histograms.xml lgtm congratulations, you have the 1000th extension function histogram value! --mark
5 years, 8 months ago (2015-04-10 17:16:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060993003/140001
5 years, 8 months ago (2015-04-10 17:22:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/13809) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-10 17:28:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060993003/160001
5 years, 8 months ago (2015-04-10 17:46:15 UTC) #24
Devlin
On 2015/04/10 17:46:15, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-10 21:13:59 UTC) #26
Dan Beam
https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (left): https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#oldcode572 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:572: registered_for_notifications_ = true; why'd you remove this? https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File ...
5 years, 8 months ago (2015-04-10 21:26:27 UTC) #27
Devlin
https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (left): https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#oldcode572 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:572: registered_for_notifications_ = true; On 2015/04/10 21:26:27, Dan Beam wrote: ...
5 years, 8 months ago (2015-04-10 21:43:05 UTC) #28
Dan Beam
https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode482 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:482: Profile* profile = Profile::FromWebUI(web_ui()); nit: instead of bringing back ...
5 years, 8 months ago (2015-04-10 21:48:02 UTC) #29
Dan Beam
lgtm either way
5 years, 8 months ago (2015-04-10 21:49:03 UTC) #30
Devlin
https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/1060993003/diff/180001/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode482 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:482: Profile* profile = Profile::FromWebUI(web_ui()); On 2015/04/10 21:48:02, Dan Beam ...
5 years, 8 months ago (2015-04-10 21:54:09 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1060993003/220001
5 years, 8 months ago (2015-04-10 23:17:54 UTC) #34
commit-bot: I haz the power
Committed patchset #7 (id:220001)
5 years, 8 months ago (2015-04-11 00:08:49 UTC) #35
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/b1e5d24b2a3b1bb95b4cbb83b752d775952c91cc Cr-Commit-Position: refs/heads/master@{#324726}
5 years, 8 months ago (2015-04-11 00:09:40 UTC) #36
Nico
I'll revert this as it could've caused http://crbug.com/476408. The "Revert" button doesn't seem to work ...
5 years, 8 months ago (2015-04-13 04:04:04 UTC) #37
Nico
5 years, 8 months ago (2015-04-13 04:26:12 UTC) #39
Message was sent while issue was closed.
Manual revert here: https://codereview.chromium.org/1083573002/

Powered by Google App Engine
This is Rietveld 408576698