Issue 1083443002: Fix the test broken by https://codereview.chromium.org/1078973002 by

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1083443002: Fix the test broken by https://codereview.chromium.org/1078973002 by (Closed)

Created:
5 years, 8 months ago by Hixie

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix the test broken by https://codereview.chromium.org/1078973002 by making sure the basic.sky test exposes the right (new) DOM now that text is always wrapped in a display:paragraph div. BUG=85 R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/31cbd1f500ad28a400da5d0479490a783054a53d

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	sky/tests/TestExpectations	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/tests/framework/basic.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/framework/basic-expected.txt	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 8 months ago (2015-04-10 22:04:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31cbd1f500ad28a400da5d0479490a783054a53d (presubmit successful).