Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1083413003: Reland MIPS: Vector-ICs - speed towards the monomorphic exit as quickly as possible. (Closed)

Created:
5 years, 8 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland MIPS: Vector-ICs - speed towards the monomorphic exit as quickly as possible. Port 35a67b745d862c5b1f584c2786ebf1369dc4f1ff Original commit message: Thanks to some careful assumptions, we can examine the object found at vector[slot] and trust it's a heap object where the second field is either a map if it's a WeakCell, or definitely not a map if it's a Symbol, String or FixedArray. Use this to save a memory read. BUG= Review URL: https://codereview.chromium.org/1053843003 Cr-Commit-Position: refs/heads/master@{#27757} Committed: https://crrev.com/80f24f7a4c2037c677531db21643f20e4dffc789 Cr-Commit-Position: refs/heads/master@{#27893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -142 lines) Patch
M src/mips/code-stubs-mips.cc View 9 chunks +53 lines, -70 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 9 chunks +53 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
This should land after the fix in https://codereview.chromium.org/1074123004/
5 years, 8 months ago (2015-04-16 02:38:15 UTC) #2
mvstanton
lgtm
5 years, 8 months ago (2015-04-16 06:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083413003/1
5 years, 8 months ago (2015-04-16 15:33:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 16:05:55 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:06:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80f24f7a4c2037c677531db21643f20e4dffc789
Cr-Commit-Position: refs/heads/master@{#27893}

Powered by Google App Engine
This is Rietveld 408576698