Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1053843003: MIPS: Vector-ICs - speed towards the monomorphic exit as quickly as possible. (Closed)

Created:
5 years, 8 months ago by balazs.kilvady
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Vector-ICs - speed towards the monomorphic exit as quickly as possible. Port 35a67b745d862c5b1f584c2786ebf1369dc4f1ff Original commit message: Thanks to some careful assumptions, we can examine the object found at vector[slot] and trust it's a heap object where the second field is either a map if it's a WeakCell, or definitely not a map if it's a Symbol, String or FixedArray. Use this to save a memory read. BUG= Committed: https://crrev.com/b45a664f7bc8155d226df7efebd23fb59e5c6162 Cr-Commit-Position: refs/heads/master@{#27757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -142 lines) Patch
M src/mips/code-stubs-mips.cc View 9 chunks +53 lines, -70 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 9 chunks +53 lines, -72 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 8 months ago (2015-04-10 11:58:31 UTC) #2
paul.l...
rs-lgtm
5 years, 8 months ago (2015-04-10 14:11:56 UTC) #3
akos.palfi.imgtec
LGTM
5 years, 8 months ago (2015-04-10 14:58:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053843003/1
5 years, 8 months ago (2015-04-10 15:37:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 18:28:20 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 18:28:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b45a664f7bc8155d226df7efebd23fb59e5c6162
Cr-Commit-Position: refs/heads/master@{#27757}

Powered by Google App Engine
This is Rietveld 408576698