Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1083413002: Remove repaint's reliance on auto issuing marker feature of smoothness_controller (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
Reviewers:
eakuefner, vmiura
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove repaint's reliance on auto issuing marker feature of smoothness_controller. In order to move repaint to use the control code of TBM, we first need to remove the code that automatically issuing marker in smoothness_controller & make sure that all the pages that are paired with repaint must issue the markers themselves in the page. BUG=444703 Committed: https://crrev.com/411de6cde54d2f10092731a814763d440cae9a23 Cr-Commit-Position: refs/heads/master@{#325355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M tools/perf/measurements/repaint.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 2 chunks +8 lines, -5 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_repaint.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
5 years, 8 months ago (2015-04-15 18:43:13 UTC) #2
vmiura
lgtm
5 years, 8 months ago (2015-04-15 21:35:45 UTC) #3
eakuefner
lgtm
5 years, 8 months ago (2015-04-15 21:38:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083413002/1
5 years, 8 months ago (2015-04-15 21:38:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 00:22:55 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 00:23:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/411de6cde54d2f10092731a814763d440cae9a23
Cr-Commit-Position: refs/heads/master@{#325355}

Powered by Google App Engine
This is Rietveld 408576698