Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/perf/measurements/smoothness_controller.py

Issue 1083413002: Remove repaint's reliance on auto issuing marker feature of smoothness_controller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/repaint_unittest.py ('k') | tools/perf/page_sets/key_mobile_sites_repaint.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_controller.py
diff --git a/tools/perf/measurements/smoothness_controller.py b/tools/perf/measurements/smoothness_controller.py
index 4291fbd9e3e0d37a9eff89cbb0a3df0337e9e01d..95c71df9e478e29678e2b25ce76fc657386c7870 100644
--- a/tools/perf/measurements/smoothness_controller.py
+++ b/tools/perf/measurements/smoothness_controller.py
@@ -21,11 +21,12 @@ RUN_SMOOTH_ACTIONS = 'RunSmoothAllActions'
class SmoothnessController(object):
- def __init__(self):
+ def __init__(self, auto_issuing_marker=True):
self._timeline_model = None
self._trace_data = None
self._interaction = None
self._surface_flinger_trace_data = None
+ self._auto_issuing_marker = auto_issuing_marker
def SetUp(self, page, tab):
# FIXME: Remove webkit.console when blink.console lands in chromium and
@@ -43,13 +44,15 @@ class SmoothnessController(object):
def Start(self, tab):
# Start the smooth marker for all smooth actions.
runner = action_runner.ActionRunner(tab)
- self._interaction = runner.CreateInteraction(
- RUN_SMOOTH_ACTIONS)
- self._interaction.Begin()
+ if self._auto_issuing_marker:
+ self._interaction = runner.CreateInteraction(
+ RUN_SMOOTH_ACTIONS)
+ self._interaction.Begin()
def Stop(self, tab):
# End the smooth marker for all smooth actions.
- self._interaction.End()
+ if self._auto_issuing_marker:
+ self._interaction.End()
self._trace_data = tab.browser.platform.tracing_controller.Stop()
self._timeline_model = TimelineModel(self._trace_data)
« no previous file with comments | « tools/perf/measurements/repaint_unittest.py ('k') | tools/perf/page_sets/key_mobile_sites_repaint.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698