pkg/analysis_server/test/edit/refactoring_test.dart - Issue 1083223003: Fix additional cases where analysis server might send null, violating protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 1083223003: Fix additional cases where analysis server might send null, violating protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/extract_method.dart ('k') | pkg/analysis_server/tool/spec/codegen_dart_protocol.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/edit/refactoring_test.dart

diff --git a/pkg/analysis_server/test/edit/refactoring_test.dart b/pkg/analysis_server/test/edit/refactoring_test.dart

index 2ceb1cddc53b5014a12918b82f78080e5cfa9204..1ab34e26e529f86e5d6cb86bc2ee44386f86fbf3 100644

--- a/pkg/analysis_server/test/edit/refactoring_test.dart

+++ b/pkg/analysis_server/test/edit/refactoring_test.dart

@@ -991,7 +991,10 @@ main() {

@reflectiveTest

class MoveFileTest extends _AbstractGetRefactoring_Test {

- MoveFileOptions options = new MoveFileOptions(null);

+ void _setOptions(String newFile) {

+ options = new MoveFileOptions(newFile);

+ }

+ MoveFileOptions options;

scheglov 2015/04/16 15:01:10 Sort?

Paul Berry 2015/04/16 15:42:21 Done.

test_OK() {

resourceProvider.newFile('/project/bin/lib.dart', '');

@@ -999,7 +1002,7 @@ class MoveFileTest extends _AbstractGetRefactoring_Test {

import 'dart:math';

import 'lib.dart';

''');

- options.newFile = '/project/test.dart';

+ _setOptions('/project/test.dart');

return assertSuccessfulRefactoring(() {

return _sendMoveRequest();

}, '''