Fix additional cases where analysis server might send null, violating protocol.

pkg/analysis_server/test/edit/refactoring_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.edit.refactoring;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/edit/edit_domain.dart';
 import 'package:analysis_server/src/plugin/server_plugin.dart';
@@ skipping 973 matching lines @@
   Future<Response> _sendInlineRequest(String search) {
     Request request = new EditGetRefactoringParams(
         RefactoringKind.INLINE_METHOD, testFile, findOffset(search), 0, false,
         options: options).toRequest('0');
     return serverChannel.sendRequest(request);
   }
 }
 
 @reflectiveTest
 class MoveFileTest extends _AbstractGetRefactoring_Test {
-  MoveFileOptions options = new MoveFileOptions(null);
+  void _setOptions(String newFile) {
+    options = new MoveFileOptions(newFile);
+  }
+  MoveFileOptions options;

[scheglov, 2015/04/16 15:01:10]

Sort?

[Paul Berry, 2015/04/16 15:42:21]

Done.

 
   test_OK() {
     resourceProvider.newFile('/project/bin/lib.dart', '');
     addTestFile('''
 import 'dart:math';
 import 'lib.dart';
 ''');
-    options.newFile = '/project/test.dart';
+    _setOptions('/project/test.dart');
     return assertSuccessfulRefactoring(() {
       return _sendMoveRequest();
     }, '''
 import 'dart:math';
 import 'bin/lib.dart';
 ''');
   }
 
   Future<Response> _sendMoveRequest() {
     Request request = new EditGetRefactoringParams(
@@ skipping 734 matching lines @@
         .toRequest('0');
     return _assertErrorResposeNoIndex(request);
   }
 
   _assertErrorResposeNoIndex(Request request) async {
     Response response = await serverChannel.sendRequest(request);
     expect(response.error, isNotNull);
     expect(response.error.code, RequestErrorCode.NO_INDEX_GENERATED);
   }
 }