Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1083193007: Remove legacy Module Verifier. (Closed)

Created:
5 years, 8 months ago by grt (UTC plus 2)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove legacy Module Verifier. BUG=480352, 454716, 412045 Committed: https://crrev.com/65a1513fcdb8f2f1e10b87d39eebacc1f70d803f Cr-Commit-Position: refs/heads/master@{#330603}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync to position 330514; updated histograms.xml #

Messages

Total messages: 22 (10 generated)
grt (UTC plus 2)
Hi Anthony, Please have a look, thanks.
5 years, 8 months ago (2015-04-23 17:50:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083193007/20001
5 years, 8 months ago (2015-04-23 17:50:23 UTC) #5
anthonyvd
lgtm % histograms.xml comment. https://codereview.chromium.org/1083193007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1083193007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode15655 tools/metrics/histograms/histograms.xml:15655: <histogram name="ModuleIntegrityVerification.Difference" units="bytes"> It's now ...
5 years, 8 months ago (2015-04-23 18:34:26 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-23 19:01:26 UTC) #8
grt (UTC plus 2)
+asvitkine for tools/metrics OWNERS review +mattm for chrome/common/safe_browsing OWNERS review https://codereview.chromium.org/1083193007/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1083193007/diff/20001/tools/metrics/histograms/histograms.xml#oldcode15655 ...
5 years, 7 months ago (2015-05-19 18:54:54 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083193007/40001
5 years, 7 months ago (2015-05-19 18:55:23 UTC) #14
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-05-19 20:15:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 20:24:21 UTC) #17
mattm
lgtm
5 years, 7 months ago (2015-05-19 20:47:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083193007/40001
5 years, 7 months ago (2015-05-19 20:50:52 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-19 20:57:15 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:57:58 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65a1513fcdb8f2f1e10b87d39eebacc1f70d803f
Cr-Commit-Position: refs/heads/master@{#330603}

Powered by Google App Engine
This is Rietveld 408576698