chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc - Issue 1083193007: Remove legacy Module Verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

Issue 1083193007: Remove legacy Module Verifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync to position 330514; updated histograms.xml Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc ('k') | chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

index 6a394e3525768cc6fb7e3b2662b02ba53d20f67d..2808faff69086d14a5b41bb817326e0cf901eb3a 100644

--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc

@@ -208,7 +208,8 @@ TEST(SafeBrowsingEnvironmentDataCollectionWinTest, VerifyLoadedModules) {

ASSERT_LE(1, process_report.module_state_size());

#if !defined(ADDRESS_SANITIZER)

EXPECT_EQ(1, process_report.module_state_size());

- EXPECT_EQ(1, process_report.module_state(0).modified_export_size());

+ EXPECT_EQ(1, process_report.module_state(0).modification_size());

+ EXPECT_TRUE(process_report.module_state(0).modification(0).has_export_name());

#endif

EXPECT_EQ(base::WideToUTF8(kTestDllNames[0]),

@@ -219,7 +220,7 @@ TEST(SafeBrowsingEnvironmentDataCollectionWinTest, VerifyLoadedModules) {

// See comment above about AddressSantizier.

#if !defined(ADDRESS_SANITIZER)

EXPECT_EQ(std::string(kTestExportName),

- process_report.module_state(0).modified_export(0));

+ process_report.module_state(0).modification(0).export_name());

#endif

}

#endif // _WIN64