Make calls to AtomicString(const String&) explicit in html/

Source/core/html/HTMLAnchorElement.cpp

Index: Source/core/html/HTMLAnchorElement.cpp
diff --git a/Source/core/html/HTMLAnchorElement.cpp b/Source/core/html/HTMLAnchorElement.cpp
index dfba54b128325cf3e641e46c3f013482ac888e40..5ce299c56ed92aad29736dd284a3ba1e3c5f84c2 100644
--- a/Source/core/html/HTMLAnchorElement.cpp
+++ b/Source/core/html/HTMLAnchorElement.cpp
@@ -346,7 +346,7 @@ String HTMLAnchorElement::input() const
 
 void HTMLAnchorElement::setInput(const String& value)

[eseidel, 2013/12/31 23:22:35]

Probably makes sense as an AtomicString.  AtomicString is all about storage for
long-lived strings.  Exposing accesors which return AtomicSTrings means "I'm
holding onto this common string", and taking an AtomicString is "whatever you
apss into me is likely a common string which I'm holding on to".

In any case, if tehre are reasons (like this being a virtual) why this shouldn't
be AtomicString yet, that's fine too.

[Inactive, 2014/01/01 19:26:29]

The reason I did not update it is because input() / setInput() are virtual and
overridden in WorkerLocation.h as well.

 {
-    setHref(value);
+    setHref(AtomicString(value));
 }
 
 bool HTMLAnchorElement::hasRel(uint32_t relation) const
@@ -354,7 +354,7 @@ bool HTMLAnchorElement::hasRel(uint32_t relation) const
     return m_linkRelations & relation;
 }
 
-void HTMLAnchorElement::setRel(const String& value)
+void HTMLAnchorElement::setRel(const AtomicString& value)
 {
     m_linkRelations = 0;
     SpaceSplitString newLinkRelations(value, true);
@@ -424,7 +424,7 @@ void HTMLAnchorElement::handleClick(Event* event)
         if (!hasRel(RelationNoReferrer)) {
             String referrer = SecurityPolicy::generateReferrerHeader(document().referrerPolicy(), completedURL, document().outgoingReferrer());
             if (!referrer.isEmpty())
-                request.setHTTPReferrer(referrer);
+                request.setHTTPReferrer(AtomicString(referrer));
         }
 
         frame->loader().client()->loadURLExternally(request, NavigationPolicyDownload, fastGetAttribute(downloadAttr));