Make calls to AtomicString(const String&) explicit in html/

Source/core/html/HTMLAnchorElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Simon Hausmann <hausmann@kde.org>
  * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 326 matching lines @@
 void HTMLAnchorElement::setURL(const KURL& url)
 {
     setHref(AtomicString(url.string()));
 }
 
 String HTMLAnchorElement::input() const
 {
     return getAttribute(hrefAttr);
 }
 
 void HTMLAnchorElement::setInput(const String& value)

[eseidel, 2013/12/31 23:22:35]

Probably makes sense as an AtomicString.  AtomicString is all about storage for
long-lived strings.  Exposing accesors which return AtomicSTrings means "I'm
holding onto this common string", and taking an AtomicString is "whatever you
apss into me is likely a common string which I'm holding on to".

In any case, if tehre are reasons (like this being a virtual) why this shouldn't
be AtomicString yet, that's fine too.

[Inactive, 2014/01/01 19:26:29]

The reason I did not update it is because input() / setInput() are virtual and
overridden in WorkerLocation.h as well.

 {
-    setHref(value);
+    setHref(AtomicString(value));
 }
 
 bool HTMLAnchorElement::hasRel(uint32_t relation) const
 {
     return m_linkRelations & relation;
 }
 
-void HTMLAnchorElement::setRel(const String& value)
+void HTMLAnchorElement::setRel(const AtomicString& value)
 {
     m_linkRelations = 0;
     SpaceSplitString newLinkRelations(value, true);
     // FIXME: Add link relations as they are implemented
     if (newLinkRelations.contains("noreferrer"))
         m_linkRelations |= RelationNoReferrer;
 }
 
 const AtomicString& HTMLAnchorElement::name() const
 {
@@ skipping 49 matching lines @@
     // sent out.
     sendPings(completedURL);
 
     ResourceRequest request(completedURL);
     if (prefetchEventHandler()->hasIssuedPreconnect())
         frame->loader().client()->dispatchWillRequestAfterPreconnect(request);
     if (hasAttribute(downloadAttr)) {
         if (!hasRel(RelationNoReferrer)) {
             String referrer = SecurityPolicy::generateReferrerHeader(document().referrerPolicy(), completedURL, document().outgoingReferrer());
             if (!referrer.isEmpty())
-                request.setHTTPReferrer(referrer);
+                request.setHTTPReferrer(AtomicString(referrer));
         }
 
         frame->loader().client()->loadURLExternally(request, NavigationPolicyDownload, fastGetAttribute(downloadAttr));
     } else {
         FrameLoadRequest frameRequest(&document(), request, target());
         frameRequest.setTriggeringEvent(event);
         if (hasRel(RelationNoReferrer))
             frameRequest.setShouldSendReferrer(NeverSendReferrer);
         frame->loader().load(frameRequest);
     }
@@ skipping 251 matching lines @@
     preconnectToURL(url, motivation);
     m_hasIssuedPreconnect = true;
 }
 
 bool HTMLAnchorElement::isInteractiveContent() const
 {
     return true;
 }
 
 }