|
|
Created:
5 years, 8 months ago by Daniele Castagna Modified:
5 years, 7 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a 4k 60 fps vp9 smpte bars video to telemetry tests.
This video is 10 seconds of SMPTE color bars.
The load on the vp9 decoder is relatively low, in this way we can better
measure the load on the compositor.
The video has been generated using libavfilter.
BUG=
Committed: https://crrev.com/8c579956a575d458dd4fb6231f8f341be136c5c7
Cr-Commit-Position: refs/heads/master@{#329332}
Patch Set 1 #Patch Set 2 : Remove a new line at the end of the file. #Patch Set 3 : Remove skip_basic_metrics and set add_browser_metrics. #Patch Set 4 : Add 3840x2160, rename sha1 file. #Patch Set 5 : Forgot to add the py file. #Patch Set 6 : Remove 3840x2160 video. #Patch Set 7 : Default to 0 if metric is not present in dict. #
Messages
Total messages: 26 (9 generated)
dcastagna@chromium.org changed reviewers: + prabhur@chromium.org
prabhur@chromium.org changed reviewers: + dalecurtis@chromium.org
dalecurtis@, could you take a look at the choice of the 4k60fps video being added? Is there any specific requirements around how it needs to be encoded ?
dalecurtis@chromium.org changed reviewers: + fgalligan@chromium.org, renganathan@chromium.org
Can you post the encoding settings you used? +pangu, fgalligan for encoding recommendations.
On 2015/04/14 at 22:57:49, dalecurtis wrote: > Can you post the encoding settings you used? +pangu, fgalligan for encoding recommendations. The video has been generated with: ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a 64k -f webm smpte_4k60_vp9.webm the encoding settings are copied from here: http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide
On 2015/04/14 23:00:59, Daniele Castagna wrote: > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > Can you post the encoding settings you used? +pangu, fgalligan for encoding > recommendations. > > The video has been generated with: > > ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf > drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' > -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 > -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a 64k -f > webm smpte_4k60_vp9.webm > > the encoding settings are copied from here: > http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide Did you do a one pass first? I guess it doesn't matter, if you are satisfied with the quality. Should you change the name of the file to webm smpte_4096x2160_60fps_vp9.webm or something? I just don't want to confuse someone later that might think the file is a different resolution like 3840x2160. Also why not at 3840x2160? Should we have both? I know displaying on TVs you will need to scale the 4096x2160 to fit UHD, which is more overhead.
On 2015/04/15 at 01:12:01, fgalligan wrote: > On 2015/04/14 23:00:59, Daniele Castagna wrote: > > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > > Can you post the encoding settings you used? +pangu, fgalligan for encoding > > recommendations. > > > > The video has been generated with: > > > > ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf > > drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' > > -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 > > -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a 64k -f > > webm smpte_4k60_vp9.webm > > > > the encoding settings are copied from here: > > http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide > > Did you do a one pass first? I guess it doesn't matter, if you are satisfied with the quality. > Yes I did, just forgot to copy and paste. > Should you change the name of the file to webm smpte_4096x2160_60fps_vp9.webm or something? I just don't want to confuse someone later that might think the file is a different resolution like 3840x2160. > Sure. > Also why not at 3840x2160? Should we have both? I know displaying on TVs you will need to scale the 4096x2160 to fit UHD, which is more overhead. Good point, the HD videos on youtube seems to be 3840x2160. Not sure if we should keep 4096x2160 too since the difference with 3840x2160 is minimal.
On 2015/04/15 18:35:02, Daniele Castagna wrote: > On 2015/04/15 at 01:12:01, fgalligan wrote: > > On 2015/04/14 23:00:59, Daniele Castagna wrote: > > > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > > > Can you post the encoding settings you used? +pangu, fgalligan for > encoding > > > recommendations. > > > > > > The video has been generated with: > > > > > > ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf > > > > drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' > > > -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 > > > -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a 64k -f > > > webm smpte_4k60_vp9.webm > > > > > > the encoding settings are copied from here: > > > http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide > > > > Did you do a one pass first? I guess it doesn't matter, if you are satisfied > with the quality. > > > Yes I did, just forgot to copy and paste. > > > Should you change the name of the file to webm smpte_4096x2160_60fps_vp9.webm > or something? I just don't want to confuse someone later that might think the > file is a different resolution like 3840x2160. > > > Sure. > > > Also why not at 3840x2160? Should we have both? I know displaying on TVs you > will need to scale the 4096x2160 to fit UHD, which is more overhead. > Good point, the HD videos on youtube seems to be 3840x2160. Not sure if we > should keep 4096x2160 too since the difference with 3840x2160 is minimal. The problem with 4096x2160 is that you will need to scale down as most 4k devices are 3840x2160 (at least it was 6-12 months ago). As you know, just doing copies at 4k can be very expensive. Doing a scale in software will be more expensive than a copy. If all the scaling is done in hardware then it might not matter. I'm pretty sure Chrome will have to handle both resolutions. If we can only accommodate one right now, then I would probably go with 3840x2160.
On 2015/04/15 at 23:57:35, fgalligan wrote: > On 2015/04/15 18:35:02, Daniele Castagna wrote: > > On 2015/04/15 at 01:12:01, fgalligan wrote: > > > On 2015/04/14 23:00:59, Daniele Castagna wrote: > > > > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > > > > Can you post the encoding settings you used? +pangu, fgalligan for > > encoding > > > > recommendations. > > > > > > > > The video has been generated with: > > > > > > > > ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf > > > > > > drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' > > > > -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 > > > > -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a 64k -f > > > > webm smpte_4k60_vp9.webm > > > > > > > > the encoding settings are copied from here: > > > > http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide > > > > > > Did you do a one pass first? I guess it doesn't matter, if you are satisfied > > with the quality. > > > > > Yes I did, just forgot to copy and paste. > > > > > Should you change the name of the file to webm smpte_4096x2160_60fps_vp9.webm > > or something? I just don't want to confuse someone later that might think the > > file is a different resolution like 3840x2160. > > > > > Sure. > > > > > Also why not at 3840x2160? Should we have both? I know displaying on TVs you > > will need to scale the 4096x2160 to fit UHD, which is more overhead. > > Good point, the HD videos on youtube seems to be 3840x2160. Not sure if we > > should keep 4096x2160 too since the difference with 3840x2160 is minimal. > > The problem with 4096x2160 is that you will need to scale down as most 4k devices are 3840x2160 (at least it was 6-12 months ago). As you know, just doing copies at 4k can be very expensive. Doing a scale in software will be more expensive than a copy. If all the scaling is done in hardware then it might not matter. > > I'm pretty sure Chrome will have to handle both resolutions. If we can only accommodate one right now, then I would probably go with 3840x2160. Let's start with 3840x2160 then.
On 2015/04/16 16:13:26, Daniele Castagna wrote: > On 2015/04/15 at 23:57:35, fgalligan wrote: > > On 2015/04/15 18:35:02, Daniele Castagna wrote: > > > On 2015/04/15 at 01:12:01, fgalligan wrote: > > > > On 2015/04/14 23:00:59, Daniele Castagna wrote: > > > > > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > > > > > Can you post the encoding settings you used? +pangu, fgalligan for > > > encoding > > > > > recommendations. > > > > > > > > > > The video has been generated with: > > > > > > > > > > ffmpeg -f lavfi -i smptebars=duration=10:size=4096x2160:rate=60 -vf > > > > > > > > > drawtext='fontsize=2000:fontfile=/usr/share/fonts/truetype/freefont/FreeSans.ttf:x=10:y=10:text=%{n}' > > > > > -c:v libvpx-vp9 -pass 2 -b:v 1000K -threads 8 -speed 1 -tile-columns 6 > > > > > -frame-parallel 1 -auto-alt-ref 1 -lag-in-frames 25 -c:a libopus -b:a > 64k -f > > > > > webm smpte_4k60_vp9.webm > > > > > > > > > > the encoding settings are copied from here: > > > > > http://wiki.webmproject.org/ffmpeg/vp9-encoding-guide > > > > > > > > Did you do a one pass first? I guess it doesn't matter, if you are > satisfied > > > with the quality. > > > > > > > Yes I did, just forgot to copy and paste. > > > > > > > Should you change the name of the file to webm > smpte_4096x2160_60fps_vp9.webm > > > or something? I just don't want to confuse someone later that might think > the > > > file is a different resolution like 3840x2160. > > > > > > > Sure. > > > > > > > Also why not at 3840x2160? Should we have both? I know displaying on TVs > you > > > will need to scale the 4096x2160 to fit UHD, which is more overhead. > > > Good point, the HD videos on youtube seems to be 3840x2160. Not sure if we > > > should keep 4096x2160 too since the difference with 3840x2160 is minimal. > > > > The problem with 4096x2160 is that you will need to scale down as most 4k > devices are 3840x2160 (at least it was 6-12 months ago). As you know, just doing > copies at 4k can be very expensive. Doing a scale in software will be more > expensive than a copy. If all the scaling is done in hardware then it might not > matter. > > > > I'm pretty sure Chrome will have to handle both resolutions. If we can only > accommodate one right now, then I would probably go with 3840x2160. > > Let's start with 3840x2160 then. LGTM
lgtm
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083073003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
dcastagna@chromium.org changed reviewers: + sullivan@chromium.org
+sullivan for owner's approval.
lgtm Please ensure this passes on perf try bots before submitting: http://www.chromium.org/developers/performance-try-bots
Patchset #7 (id:120001) has been deleted
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org, fgalligan@chromium.org, dalecurtis@chromium.org Link to the patchset: https://codereview.chromium.org/1083073003/#ps140001 (title: "Default to 0 if metric is not present in dict.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083073003/140001
Message was sent while issue was closed.
Committed patchset #7 (id:140001)
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/8c579956a575d458dd4fb6231f8f341be136c5c7 Cr-Commit-Position: refs/heads/master@{#329332} |