Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 1083073003: Add a 4k 60 fps vp9 smpte bars video to telemetry tests. (Closed)

Created:
5 years, 8 months ago by Daniele Castagna
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a 4k 60 fps vp9 smpte bars video to telemetry tests. This video is 10 seconds of SMPTE color bars. The load on the vp9 decoder is relatively low, in this way we can better measure the load on the compositor. The video has been generated using libavfilter. BUG= Committed: https://crrev.com/8c579956a575d458dd4fb6231f8f341be136c5c7 Cr-Commit-Position: refs/heads/master@{#329332}

Patch Set 1 #

Patch Set 2 : Remove a new line at the end of the file. #

Patch Set 3 : Remove skip_basic_metrics and set add_browser_metrics. #

Patch Set 4 : Add 3840x2160, rename sha1 file. #

Patch Set 5 : Forgot to add the py file. #

Patch Set 6 : Remove 3840x2160 video. #

Patch Set 7 : Default to 0 if metric is not present in dict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M tools/perf/metrics/system_memory.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_video_cases.py View 1 2 3 4 5 2 chunks +14 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_video_cases/smpte_3840x2160_60fps_vp9.webm.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 26 (9 generated)
Daniele Castagna
5 years, 8 months ago (2015-04-14 22:34:50 UTC) #2
prabhur1
dalecurtis@, could you take a look at the choice of the 4k60fps video being added? ...
5 years, 8 months ago (2015-04-14 22:56:06 UTC) #4
DaleCurtis
Can you post the encoding settings you used? +pangu, fgalligan for encoding recommendations.
5 years, 8 months ago (2015-04-14 22:57:49 UTC) #6
Daniele Castagna
On 2015/04/14 at 22:57:49, dalecurtis wrote: > Can you post the encoding settings you used? ...
5 years, 8 months ago (2015-04-14 23:00:59 UTC) #7
fgalligan1
On 2015/04/14 23:00:59, Daniele Castagna wrote: > On 2015/04/14 at 22:57:49, dalecurtis wrote: > > ...
5 years, 8 months ago (2015-04-15 01:12:01 UTC) #8
Daniele Castagna
On 2015/04/15 at 01:12:01, fgalligan wrote: > On 2015/04/14 23:00:59, Daniele Castagna wrote: > > ...
5 years, 8 months ago (2015-04-15 18:35:02 UTC) #9
fgalligan1
On 2015/04/15 18:35:02, Daniele Castagna wrote: > On 2015/04/15 at 01:12:01, fgalligan wrote: > > ...
5 years, 8 months ago (2015-04-15 23:57:35 UTC) #10
Daniele Castagna
On 2015/04/15 at 23:57:35, fgalligan wrote: > On 2015/04/15 18:35:02, Daniele Castagna wrote: > > ...
5 years, 8 months ago (2015-04-16 16:13:26 UTC) #11
fgalligan1
On 2015/04/16 16:13:26, Daniele Castagna wrote: > On 2015/04/15 at 23:57:35, fgalligan wrote: > > ...
5 years, 8 months ago (2015-04-17 17:09:17 UTC) #12
DaleCurtis
lgtm
5 years, 8 months ago (2015-04-17 17:10:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083073003/100001
5 years, 8 months ago (2015-04-17 17:26:02 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/57181)
5 years, 8 months ago (2015-04-17 17:38:02 UTC) #17
Daniele Castagna
+sullivan for owner's approval.
5 years, 8 months ago (2015-04-17 17:56:14 UTC) #19
sullivan
lgtm Please ensure this passes on perf try bots before submitting: http://www.chromium.org/developers/performance-try-bots
5 years, 8 months ago (2015-04-17 17:58:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083073003/140001
5 years, 7 months ago (2015-05-12 01:50:43 UTC) #24
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 7 months ago (2015-05-12 02:56:33 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:57:21 UTC) #26
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/8c579956a575d458dd4fb6231f8f341be136c5c7
Cr-Commit-Position: refs/heads/master@{#329332}

Powered by Google App Engine
This is Rietveld 408576698