tools/perf/metrics/system_memory.py - Issue 1083073003: Add a 4k 60 fps vp9 smpte bars video to telemetry tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/system_memory.py

Issue 1083073003: Add a 4k 60 fps vp9 smpte bars video to telemetry tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Default to 0 if metric is not present in dict. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/system_memory.py

diff --git a/tools/perf/metrics/system_memory.py b/tools/perf/metrics/system_memory.py

index ec3ce2e9ed542b9004411df223a94fa89c53a09f..ea02fbddbf6ef9501bca10d9ebb150605965edb5 100644

--- a/tools/perf/metrics/system_memory.py

+++ b/tools/perf/metrics/system_memory.py

@@ -117,7 +117,7 @@ def _SubtractMemoryStats(end_memory_stats, start_memory_stats):

else:

for metric in end_process_memory:

end_value = end_process_memory[metric]

- start_value = start_memory_stats[process_type][metric] or 0

+ start_value = start_memory_stats[process_type].get(metric, 0)

if 'Peak' in metric:

memory_stats[process_type][metric] = end_value

else:

« no previous file with comments | « no previous file | tools/perf/page_sets/tough_video_cases.py » ('j') | no next file with comments »