Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 108303009: Handle "url(...) none" and "url(...) currentColor" SVG paint specs (Closed)

Created:
7 years ago by fs
Modified:
7 years ago
Reviewers:
pdr., krit, Stephen Chennney
CC:
blink-reviews, krit, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Handle "url(...) none" and "url(...) currentColor" SVG paint specs Consider all paint types with a URI in paintingResourceFromSVGPaint - URI_NONE, URI_CURRENTCOLOR and URI_RGBCOLOR_ICCCOLOR were previously not considered. (The last one, URI_RGBCOLOR_ICCCOLOR, will never appear out of the parser.) Add parsing support for the URI_CURRENTCOLOR type, since it's trivial. TEST=svg/custom/fill-fallback-{none,currentcolor-{1,2}}.svg BUG=162547 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164200

Patch Set 1 #

Patch Set 2 : Added TC for 'none' fallback w/ failing url(...). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
A LayoutTests/svg/custom/fill-fallback-currentcolor-1.svg View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-currentcolor-1-expected.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-currentcolor-2.svg View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-currentcolor-2-expected.svg View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-none-1.svg View 1 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-none-1-expected.svg View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-none-2.svg View 1 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-none-2-expected.svg View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/SVGCSSParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 1 chunk +16 lines, -1 line 0 comments Download
M Source/core/svg/SVGPaint.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
7 years ago (2013-12-19 16:14:18 UTC) #1
Stephen Chennney
What is the expected behavior when the fallback is "none" and the URL is not ...
7 years ago (2013-12-19 16:41:54 UTC) #2
fs
On 2013/12/19 16:41:54, Stephen Chenney wrote: > What is the expected behavior when the fallback ...
7 years ago (2013-12-19 17:15:31 UTC) #3
fs
On 2013/12/19 17:15:31, fs wrote: > On 2013/12/19 16:41:54, Stephen Chenney wrote: > > What ...
7 years ago (2013-12-19 17:26:31 UTC) #4
fs
7 years ago (2013-12-19 17:26:42 UTC) #5
Stephen Chennney
LGTM. The total failure case is still worth it for crash checking etc. as the ...
7 years ago (2013-12-19 21:48:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/108303009/20001
7 years ago (2013-12-19 21:48:43 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-19 21:57:25 UTC) #8
Message was sent while issue was closed.
Change committed as 164200

Powered by Google App Engine
This is Rietveld 408576698