Source/core/css/SVGCSSParser.cpp - Issue 108303009: Handle "url(...) none" and "url(...) currentColor" SVG paint specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/SVGCSSParser.cpp

Issue 108303009: Handle "url(...) none" and "url(...) currentColor" SVG paint specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added TC for 'none' fallback w/ failing url(...). Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/SVGCSSParser.cpp

diff --git a/Source/core/css/SVGCSSParser.cpp b/Source/core/css/SVGCSSParser.cpp

index 8c07b148933d3dc830b09065e00b33e5286b349b..f2f9a51cec401a3067e060adda75df083faa7dab 100644

--- a/Source/core/css/SVGCSSParser.cpp

+++ b/Source/core/css/SVGCSSParser.cpp

@@ -197,6 +197,8 @@ bool CSSParser::parseSVGValue(CSSPropertyID propId, bool important)

parsedValue = SVGPaint::createURIAndColor(value->string, c);

else if (m_valueList->current()->id == CSSValueNone)

parsedValue = SVGPaint::createURIAndNone(value->string);

+ else if (m_valueList->current()->id == CSSValueCurrentcolor)

+ parsedValue = SVGPaint::createURIAndCurrentColor(value->string);

}

if (!parsedValue)

parsedValue = SVGPaint::createURI(value->string);

« no previous file with comments | « LayoutTests/svg/custom/fill-fallback-none-2-expected.svg ('k') | Source/core/rendering/svg/SVGResources.cpp » ('j') | no next file with comments »