Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 1083003004: bindings: Moves toV8 and v8SetReturnValue out to ToV8.h and V8Binding.h. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 56d59f21441962ef56cf435de9ae52eeba5558fc..83a91efb6ce3d4033035bd2add6a7dcee31927b4 100644
--- a/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -345,25 +345,4 @@ bool V8Window::indexedSecurityCheckCustom(v8::Local<v8::Object> host, uint32_t i
return securityCheck(host);
}
-v8::Handle<v8::Value> toV8(DOMWindow* window, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
- // Notice that we explicitly ignore creationContext because the LocalDOMWindow is its own creationContext.
-
- if (!window)
- return v8::Null(isolate);
- // Initializes environment of a frame, and return the global object
- // of the frame.
- Frame * frame = window->frame();
- if (!frame)
- return v8Undefined();
-
- v8::Local<v8::Context> context = toV8Context(frame, DOMWrapperWorld::current(isolate));
- if (context.IsEmpty())
- return v8Undefined();
-
- v8::Local<v8::Object> global = context->Global();
- ASSERT(!global.IsEmpty());
- return global;
-}
-
} // namespace blink
« no previous file with comments | « Source/bindings/core/v8/custom/V8EventTargetCustom.cpp ('k') | Source/bindings/core/v8/custom/V8WorkerGlobalScopeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698