Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp

Issue 1083003004: bindings: Moves toV8 and v8SetReturnValue out to ToV8.h and V8Binding.h. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
index 85ad9c1b0274819f7a53abeeb4806c786b27dce9..e49d1da5be0a0a93614eb3d6f4b59a7f1e64c423 100644
--- a/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp
@@ -32,24 +32,9 @@
#include "bindings/core/v8/V8EventTarget.h"
#include "bindings/core/v8/V8Window.h"
-#include "core/EventTargetNames.h"
namespace blink {
-v8::Handle<v8::Value> toV8(EventTarget* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
-{
- if (UNLIKELY(!impl))
- return v8::Null(isolate);
-
- if (impl->interfaceName() == EventTargetNames::DOMWindow)
- return toV8(static_cast<DOMWindow*>(impl), creationContext, isolate);
-
- v8::Local<v8::Value> wrapper = DOMDataStore::getWrapper(impl, isolate);
- if (!wrapper.IsEmpty())
- return wrapper;
- return impl->wrap(creationContext, isolate);
-}
-
void V8EventTarget::addEventListenerMethodEpilogueCustom(const v8::FunctionCallbackInfo<v8::Value>& info, EventTarget* impl)
{
if (info.Length() >= 2 && info[1]->IsObject() && !impl->toNode())
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698