chrome/browser/extensions/window_controller.h - Issue 10829186: Tabs API is usable without tabs permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_controller.h

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: ETU now SetString()'s for empty values Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/window_controller.h

diff --git a/chrome/browser/extensions/window_controller.h b/chrome/browser/extensions/window_controller.h

index e6e45541ae92f23febc0e285f46fa2ef7a754ddc..ec9f6e28a5a3048ef310fde6eb148a3ca728ae79 100644

--- a/chrome/browser/extensions/window_controller.h

+++ b/chrome/browser/extensions/window_controller.h

@@ -57,7 +57,8 @@ class WindowController {

virtual base::DictionaryValue* CreateWindowValue() const;

// Populates a dictionary for the Window object, including a list of tabs.

- virtual base::DictionaryValue* CreateWindowValueWithTabs() const = 0;

+ virtual base::DictionaryValue* CreateWindowValueWithTabs(

+ const extensions::Extension* extension) const = 0;

// Returns false if the window is in a state where closing the window is not

// permitted and sets |reason| if not NULL.

« no previous file with comments | « chrome/browser/extensions/menu_manager.cc ('k') | chrome/browser/ui/panels/panel.cc » ('j') | no next file with comments »