chrome/browser/extensions/menu_manager.cc - Issue 10829186: Tabs API is usable without tabs permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: ETU now SetString()'s for empty values Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/menu_manager.cc

diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc

index 9e29835393017c08436e27a6680804e6c361bcb9..aea883daba9f37b4a2b85f64e2ef15997ac31b83 100644

--- a/chrome/browser/extensions/menu_manager.cc

+++ b/chrome/browser/extensions/menu_manager.cc

@@ -643,8 +643,8 @@ void MenuManager::ExecuteCommand(Profile* profile,

// No tab info in a platform app.

if (!extension || !extension->is_platform_app()) {

// Note: web_contents only NULL in unit tests :(

- if (web_contents)

- args->Append(ExtensionTabUtil::CreateTabValue(web_contents));

+ if (web_contents && extension)

+ args->Append(ExtensionTabUtil::CreateTabValue(web_contents, extension));

else

args->Append(new DictionaryValue());

}