Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1082913006: Real fix for the Mali bug. (Closed)

Created:
5 years, 8 months ago by jvanverth1
Modified:
5 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Real fix for the Mali bug. The dFdy(st.y) computation seems to be better than the dFdx(st.x) computation on the Mali, so using that. The end result should be about the same. BUG=skia:3528 Committed: https://skia.googlesource.com/skia/+/221360a514fb4bfff5b461e83262306b2a0f36af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -87 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 6 chunks +5 lines, -30 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 4 chunks +4 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 11 chunks +12 lines, -49 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
5 years, 8 months ago (2015-04-15 19:05:15 UTC) #2
bsalomon
lgtm
5 years, 8 months ago (2015-04-15 19:24:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082913006/1
5 years, 8 months ago (2015-04-15 19:25:01 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 19:31:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/221360a514fb4bfff5b461e83262306b2a0f36af

Powered by Google App Engine
This is Rietveld 408576698