Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 108283008: Merge 241955 "Make extensions icons easier to target with gestures" (Closed)

Created:
7 years ago by tdanderson
Modified:
7 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Merge 241955 "Make extensions icons easier to target with gestures" > Make extensions icons easier to target with gestures > > The bounds of a BrowserActionView and the bounds > of its child view |button_| have the following > properties: > > - Both share a common center point. > - The bounds of |button_| are square, but the > bounds of BAV are not. > - The bounds of |button_| are contained within > the bounds of BAV. > - Both are small enough to be easily covered > by a finger. > > This is a flaw in rect-based targeting > making it difficult to correctly target > |button_| with a tap gesture. To obtain the > desired behavior, use the distance > between the center of the touch and the center > of the view (instead of the center line of > the view) to break ties among rect-based > targeting candidates. > > The use of the distance to center line was > to avoid biases against wide or tall views. > But this is not necessary because any view > which can have at least 60% of its area > covered by a touch cannot be sufficiently wide > or tall enough to benefit from such a metric. > > BUG=328182 > > Review URL: https://codereview.chromium.org/94003003 TBR=tdanderson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -69 lines) Patch
M ui/views/rect_based_targeting_utils.h View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/views/rect_based_targeting_utils.cc View 2 chunks +2 lines, -27 lines 0 comments Download
M ui/views/rect_based_targeting_utils_unittest.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M ui/views/view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/view_unittest.cc View 8 chunks +84 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tdanderson
7 years ago (2013-12-20 20:01:40 UTC) #1
tdanderson
7 years ago (2013-12-20 20:02:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r242156.

Powered by Google App Engine
This is Rietveld 408576698