Issue 1082823004: Changes Zhuyin input method's indicator string from 酷 to 注.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1082823004: Changes Zhuyin input method's indicator string from 酷 to 注. (Closed)

Created:
5 years, 8 months ago by Shu Chen

Modified:
5 years, 8 months ago

Reviewers:
James Su

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Changes Zhuyin input method's indicator string from 酷 to 注. This is a regression. The original bug was fixed by https://codereview.chromium.org/25737006. But later IMF supports defining indicator in manifest, which caused this regression. TBR=suzhe@chromium.org BUG=286623 TEST=Verified on clapper device. Committed: https://crrev.com/60eb6bf1d51acee4721dfd0a89344a62e67de2f1 Cr-Commit-Position: refs/heads/master@{#325005}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082823004/1

5 years, 8 months ago (2015-04-14 05:44:03 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-14 06:32:04 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/60eb6bf1d51acee4721dfd0a89344a62e67de2f1
Cr-Commit-Position: refs/heads/master@{#325005}