Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 25737006: Change IME indicator character from U+9177 to U+6CE8 (Closed)

Created:
7 years, 2 months ago by Seigo Nonaka
Modified:
7 years, 2 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Change IME indicator character from U+9177 to U+6CE8 BUG=286623 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230428

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Seigo Nonaka
Hi Shu, I received an issue that the indicator character should be "注" rather than ...
7 years, 2 months ago (2013-10-03 03:48:40 UTC) #1
Shu Chen
lgtm
7 years, 2 months ago (2013-10-04 12:42:28 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 2 months ago (2013-10-08 00:44:18 UTC) #3
Seigo Nonaka
Hi Zach, could you take a a look?
7 years, 2 months ago (2013-10-08 01:19:03 UTC) #4
Zachary Kuznia
lgtm
7 years, 2 months ago (2013-10-08 17:58:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/25737006/1
7 years, 2 months ago (2013-10-09 01:07:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/25737006/1
7 years, 2 months ago (2013-10-09 02:14:51 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=162913
7 years, 2 months ago (2013-10-09 07:21:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/25737006/30001
7 years, 2 months ago (2013-10-23 12:27:39 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 14:55:34 UTC) #10
Message was sent while issue was closed.
Change committed as 230428

Powered by Google App Engine
This is Rietveld 408576698