Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1082723007: Skip poppler and sqlite tests on big-endian platforms. (Closed)

Created:
5 years, 8 months ago by paul.l...
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip poppler and sqlite tests on big-endian platforms. Emscripten use of typed-arrays is little-endian only. BUG= Committed: https://crrev.com/bf06d5c9f5fccae2255c78620a264330e7eb6cd9 Cr-Commit-Position: refs/heads/master@{#28020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
paul.l...
PTAL.
5 years, 8 months ago (2015-04-22 16:50:36 UTC) #2
michael_dawson
On 2015/04/22 16:50:36, paul.l... wrote: > PTAL. Are these new tests that also depend on ...
5 years, 8 months ago (2015-04-22 16:59:01 UTC) #3
paul.l...
On 2015/04/22 16:59:01, michael_dawson wrote: > Are these new tests that also depend on LE ...
5 years, 8 months ago (2015-04-22 17:02:24 UTC) #4
michael_dawson
On 2015/04/22 17:02:24, paul.l... wrote: > On 2015/04/22 16:59:01, michael_dawson wrote: > > Are these ...
5 years, 8 months ago (2015-04-22 17:34:34 UTC) #5
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-22 21:22:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1082723007/1
5 years, 8 months ago (2015-04-22 21:35:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 22:31:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 22:32:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf06d5c9f5fccae2255c78620a264330e7eb6cd9
Cr-Commit-Position: refs/heads/master@{#28020}

Powered by Google App Engine
This is Rietveld 408576698