Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1056423004: [mjsunit] Add custom tests based on SQLite 3.8.9. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mjsunit] Add custom tests based on SQLite 3.8.9. Also adjust the test runner to remove --always-opt for FAST_VARIANTS. R=machenbach@chromium.org Committed: https://crrev.com/78f2efe0e4a7988a3c5e34bad4fb50381e73307b Cr-Commit-Position: refs/heads/master@{#27989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -4 lines 0 comments Download
M tools/presubmit.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-22 07:21:49 UTC) #1
Benedikt Meurer
Hey Michael, This removes the Massive benchmark for SQLite and replaces it with custom correctness ...
5 years, 8 months ago (2015-04-22 07:22:46 UTC) #2
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-22 07:26:28 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as 78f2efe0e4a7988a3c5e34bad4fb50381e73307b (presubmit successful).
5 years, 8 months ago (2015-04-22 07:45:23 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:18:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78f2efe0e4a7988a3c5e34bad4fb50381e73307b
Cr-Commit-Position: refs/heads/master@{#27989}

Powered by Google App Engine
This is Rietveld 408576698