[Webapp Refactor] Remove remoting.clientSession.

[Webapp Refactor] Remove remoting.clientSession.

remoting.clientSession is currently referenced for two purposes:
1. Disconnecting a session.
2. The ClientPlugin uses it to notify the clientSession when video
   frames are received.

For (1), this CL added a stop() method to the Activity interface.
Client code at access the Activity through the Application and call stop()
for disconnecting.

(2) is currently dead code that is not being used.  It is removed in this CL.

BUG=477119
Committed: https://crrev.com/d7f0d7b7cbdd2b4645bcca1b8703307b9d7266a5
Cr-Commit-Position: refs/heads/master@{#325196}

[kelvinp, 2015-04-14 23:12:26]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-04-14 23:13:14]

Patchset #1 (id:1) has been deleted

[kelvinp, 2015-04-14 23:16:32]

PTAL

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/app_rem...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/app_rem...
remoting/webapp/app_remoting/js/app_remoting.js:96:
remoting.AppRemoting.prototype.getActivity = function() {
This will be fixed to expose the correct activity in CL
https://codereview.chromium.org/1082973002/

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/app_rem...
remoting/webapp/app_remoting/js/app_remoting.js:216: var idleDetector = new
remoting.IdleDetector(
The IdleDetector should be started only when the session is connected.

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_plugin_impl.js:314: } else if (message.method ==
'onFirstFrameReceived') {
Removed as not used.

[Jamie, 2015-04-14 23:52:47]

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_plugin_impl.js:314: } else if (message.method ==
'onFirstFrameReceived') {
On 2015/04/14 23:16:32, kelvinp wrote:
> Removed as not used.

This will be used soon to log the amount of time before the first frame is
received. I think we need to keep it.

[kelvinp, 2015-04-15 00:30:21]

PTAL

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_plugin_impl.js (left):

https://codereview.chromium.org/1082383002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_plugin_impl.js:314: } else if (message.method ==
'onFirstFrameReceived') {
On 2015/04/14 23:52:47, Jamie wrote:
> On 2015/04/14 23:16:32, kelvinp wrote:
> > Removed as not used.
> 
> This will be used soon to log the amount of time before the first frame is
> received. I think we need to keep it.

Good catch. Resurrected!

[Jamie, 2015-04-15 00:38:18]

lgtm

[kelvinp, 2015-04-15 03:11:42]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-04-15 03:11:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1082383002/#ps100001
(title: "Fix browser tests")

[commit-bot: I haz the power, 2015-04-15 03:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082383002/100001

[commit-bot: I haz the power, 2015-04-15 06:17:17]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-04-15 06:18:11]

Patchset 5 (id:??) landed as
https://crrev.com/d7f0d7b7cbdd2b4645bcca1b8703307b9d7266a5
Cr-Commit-Position: refs/heads/master@{#325196}